Skip to content

fix: Instructions.resolve_template double-renders under render(modality)#6414

Merged
longcw merged 1 commit into
mainfrom
longc/fix-resolve-template-double-render
Jul 14, 2026
Merged

fix: Instructions.resolve_template double-renders under render(modality)#6414
longcw merged 1 commit into
mainfrom
longc/fix-resolve-template-double-render

Conversation

@longcw

@longcw longcw commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #6407

Emit the empty-common + full-variants shape (matching GetNameTask) instead
of a non-empty common alongside full audio/text variants, which render()
would prepend and duplicate.
@longcw longcw requested a review from a team as a code owner July 14, 2026 02:16

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@longcw longcw requested a review from tinalenguyen July 14, 2026 03:40
@longcw longcw merged commit efc573b into main Jul 14, 2026
26 checks passed
@longcw longcw deleted the longc/fix-resolve-template-double-render branch July 14, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants