libnvme: leave registry ownership alone on a reused connection - #3942
Merged
igaw merged 1 commit intoAug 28, 2026
Merged
Conversation
nvme connect wrote the ownership registry even when it did not create the controller. A bare connect against a controller nvme-stas or nvme-discoverd already holds deleted that controller's ownership entry, with no flag, no prompt and no output. The controller keeps running, but it now reads as unowned and loses the protection the registry gives it. Passing --owner=NAME to claim a controller is a stated intent and keeps working. Without --owner no intent is stated, so an existing entry is left alone. A controller the kernel just created still gets its entry cleared, since a recycled instance number can leave a stale one behind. An empty --owner= now disowns instead of recording an empty owner. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvme connect wrote the ownership registry even when it did not create the controller. A bare connect against a controller nvme-stas or nvme-discoverd already holds deleted that controller's ownership entry, with no flag, no prompt and no output. The controller keeps running, but it now reads as unowned and loses the protection the registry gives it.
Passing --owner=NAME to claim a controller is a stated intent and keeps working. Without --owner no intent is stated, so an existing entry is left alone.
A controller the kernel just created still gets its entry cleared, since a recycled instance number can leave a stale one behind. An empty --owner= now disowns instead of recording an empty owner.