doc: nvme-fabrics.conf is shared by the nvme-cli tools, not by everyone - #3938
Merged
igaw merged 1 commit intoAug 28, 2026
Merged
Conversation
nvme-fabrics.conf(5) and design/CONFIG.md both said nvme-stas reads this file, alongside "nvme connect-all" / "nvme config" and nvme-discoverd. That is wrong, and it has already been read as an invitation to make nvme-stas take parameters out of it. The nvme-cli tools and nvme-discoverd work together from this one shared file. nvme-stas is a separate orchestrator: same format, same parser, its own file, so a host can run both without either acting on the other's configuration. Say format rather than file in the three places that got this wrong, and stop calling a connection configuration host-wide: only the registry and the exclusion list are one per machine. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvme-fabrics.conf(5) and design/CONFIG.md both said nvme-stas reads this file, alongside "nvme connect-all" / "nvme config" and nvme-discoverd. That is wrong, and it has already been read as an invitation to make nvme-stas take parameters out of it.
The nvme-cli tools and nvme-discoverd work together from this one shared file. nvme-stas is a separate orchestrator: same format, same parser, its own file, so a host can run both without either acting on the other's configuration. Say format rather than file in the three places that got this wrong, and stop calling a connection configuration host-wide: only the registry and the exclusion list are one per machine.