Trader Bot: Sell on market price if maximum loss passed - #265
Open
konard wants to merge 3 commits into
Open
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #225
- Add MaximumLossPercentage setting to TradingSettings - Implement loss calculation based on average purchase price vs current market price - Add market sell order functionality for immediate execution - Integrate maximum loss protection into main trading loop - When loss exceeds threshold, cancel all orders and sell at market price - Add configuration examples with 10% maximum loss threshold - Add comprehensive logging for maximum loss protection events Fixes #225 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
marked this pull request as ready for review
September 11, 2025 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Issue Reference
Fixes #225
📋 Summary
This PR implements maximum loss protection for the TraderBot by automatically selling all positions at market price when the loss exceeds a configurable threshold.
🚀 Changes Made
Core Features
Technical Implementation
MaximumLossPercentageproperty (optional, nullable decimal)CalculateCurrentLossPercentage()method to compute real-time portfolio lossShouldTriggerMaximumLossProtection()method for threshold checkingPlaceMarketSellOrder()method for immediate market executionLogCriticalfor maximum loss eventsConfiguration Examples
appsettings.TMON.jsonandappsettings.TRUR.jsonwithMaximumLossPercentage: 10.0(10% loss threshold)🔧 How It Works
MaximumLossPercentage📊 Loss Calculation Formula
🛡️ Safety Features
MaximumLossPercentageis configured)🎛️ Configuration
Add to your appsettings.json:
{ "TradingSettings": { ... "MaximumLossPercentage": 10.0 } }✅ Testing
🤖 Generated with Claude Code