Fix detached Docker OOM status reconciliation - #149
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #148
konard
marked this pull request as ready for review
July 5, 2026 17:59
Member
Author
Working session summaryImplemented and pushed the fix for issue #148. PR: #149 What changed:
Verification:
This summary was automatically extracted from the AI working session output. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (383.1K + 6.3M cached) input tokens, 37.8K output tokens, $11.800939 cost 🤖 Models used:
📎 Log file uploaded as Gist (3493KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Auto-merged by hive-mind with --auto-merge flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
Summary
State.OOMKilled=trueas terminal in JS and Rust--status/--listenrichment, even if Docker still reports the container as running.oomKilledfield in structured and links/text output, setendTimeduring reconciliation, and resolve the exit code from the log footer, Docker's terminal/nonzero state, or a 137 fallback.running=true oomKilled=true, including the fallback case where Docker still reports exit code0.Reproduction / Verification
Before the fix, the new Issue #148 regression tests reproduced the bug: fake Docker inspect output
true 137 trueandtrue 0 trueboth left status asexecuting.After the fix, those cases return terminal
status: executed, retainoomKilled: true, setendTime, and use exit code137when no terminal Docker exit code is available.Tests
cd js && bun test ./test/session-name-status.jscargo test --manifest-path rust/Cargo.toml docker_oom_killed -- --nocapturegit diff --checkcd js && bun run checkbash scripts/check-mjs-syntax.shnode scripts/check-test-parity.mjsnode scripts/validate-changeset.mjscd js && bun run testcargo fmt --manifest-path rust/Cargo.toml --all -- --checkcargo clippy --manifest-path rust/Cargo.toml --all-targets --all-featurescargo test --manifest-path rust/Cargo.toml --all-features --verbosecargo test --manifest-path rust/Cargo.toml --doc --verboseScreenshots are not applicable; this is CLI/runtime status behavior.