Skip to content

fix(deps): bump fast-uri to patch GHSA-4c8g-83qw-93j6 - #240

Open
eleshar wants to merge 4 commits into
mainfrom
fix/fast-uri-ghsa-4c8g
Open

fix(deps): bump fast-uri to patch GHSA-4c8g-83qw-93j6#240
eleshar wants to merge 4 commits into
mainfrom
fix/fast-uri-ghsa-4c8g

Conversation

@eleshar

@eleshar eleshar commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • npm ls fast-uri resolves cleanly to 3.1.3 under ajv@8.17.1
  • package-lock.json is valid JSON, diff is a 3-line version/resolved/integrity bump only

ajv@8.17.1 already accepts fast-uri ^3.0.1, so this is a lockfile bump
within the existing range -- no override or ajv bump needed.
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@eleshar, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ac9af10-05c6-4016-b1e3-cef88c87762a

📥 Commits

Reviewing files that changed from the base of the PR and between 35fec58 and d59e4e1.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • composer.json
  • includes/classes/class-frontend.php
  • includes/classes/class-images.php
  • includes/classes/class-setup.php
  • includes/classes/vendors/class-woocommerce.php
  • includes/patterns/cards/posts-style1-cards.php
  • includes/patterns/cards/woo-style2-cards.php
  • includes/patterns/cards/woo-style3-cards.php

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6344db1e-f1a8-47b2-b51b-54dc9f36e72d

📥 Commits

Reviewing files that changed from the base of the PR and between b42b02e and 35fec58.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • composer.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated development tooling for PHP coding standards and code quality checks.
    • Removed duplicate Composer configuration while retaining plugin permissions.

Walkthrough

Composer now uses one consolidated configuration block. Development dependencies now contain PHP_CodeSniffer and WPCS. Existing repository, stability, licence, and plugin permission settings remain.

Changes

Composer tooling

Layer / File(s) Summary
Consolidate Composer configuration
composer.json
Removes the duplicate configuration block and replaces the previous development dependencies with PHP_CodeSniffer and WPCS.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 35fec

This PR updates fast-uri to the patched 3.1.3 release within the existing dependency range, with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fast-uri security patch, which matches the pull request's primary objective.
Description check ✅ Passed The description explains the fast-uri update, security advisory, dependency constraints, and validation steps, which relate directly to the objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fast-uri-ghsa-4c8g

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

composer.json had two "config" and two "require-dev" keys; JSON silently
keeps only the last of each, so an earlier attempt to allow the
composer/installers plugin was discarded and composer install has been
failing since at least 2026-07-17 (pre-existing, confirmed on main). Removes
the dead shadowed blocks and keeps composer/installers in the one effective
allow-plugins list.

Does not add the missing phpcs.xml.dist that "composer lint" also needs --
authoring a WPCS ruleset is a separate decision for this repo's maintainers,
not something to improvise inside a dependency-security PR.
…solves

.phpcs.xml.dist (the ruleset the CI lint job actually runs) references the
PHPCompatibilityWP standard, provided by phpcompatibility/phpcompatibility-wp.
That package was only ever declared in the dead, JSON-key-shadowed
require-dev block removed in the previous commit -- restoring it here, in
the one effective require-dev, is what that removal was missing.

Also fixes composer.json's own format/lint scripts, which pointed at
phpcs.xml.dist (no leading dot) -- a file that has never existed in this
repo. The GitHub Actions lint job always used the correct .phpcs.xml.dist
directly; only the composer scripts were wrong.

Confirmed locally: ./vendor/bin/phpcs -p --standard=.phpcs.xml.dist now
runs to completion instead of erroring on the missing sniff. It reports 11
pre-existing style violations (trailing whitespace, extra blank lines)
across files this PR does not touch -- out of scope for a dependency-
security fix; left to a separate cleanup.
Mechanical only (trailing whitespace, blank-line trailing whitespace, one
comment spacing) -- run via ./vendor/bin/phpcbf now that the lint pipeline
actually executes. 7 errors and 6 warnings remain in class-frontend.php and
class-images.php that need a real code decision (mixed boolean operators
without parens, unused callback params, doc-comment capitalization) --
left for the maintainers, not auto-fixable and not part of this PR's scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant