Skip to content

RHIDP-14083: fix: set EXTERNAL_PROVIDERS_DIR in image for unified config - #2373

Open
Jdubrick wants to merge 1 commit into
lightspeed-core:mainfrom
Jdubrick:fix-providers-unified-config
Open

RHIDP-14083: fix: set EXTERNAL_PROVIDERS_DIR in image for unified config#2373
Jdubrick wants to merge 1 commit into
lightspeed-core:mainfrom
Jdubrick:fix-providers-unified-config

Conversation

@Jdubrick

@Jdubrick Jdubrick commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

  • The default_run.yaml defaults the external providers directory to ~/.llama/providers.d if this environment variable is unset. As part of the image build however the lightspeed-providers external providers are added to /app-root/providers.d. Adding this environment variable ensures that unified config users get the correct path set.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • New Features
    • Added runtime support for configuring external providers through the application environment.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a9f66383-1ab3-4bf2-9cee-2b446ae657ac

📥 Commits

Reviewing files that changed from the base of the PR and between c4a3e40 and 68e0d0c.

📒 Files selected for processing (1)
  • deploy/lightspeed-stack/Containerfile
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-7-on-pull-request
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
🧰 Additional context used
📓 Path-based instructions (1)
**/*

📄 CodeRabbit inference engine (Custom checks)

**/*: Flag meaningful O(n^2)+ algorithms on non-trivial inputs, including handlers and Kubernetes list operations.
Flag N+1 patterns that list items and then query once per item, including Kubernetes API and database access.
Flag expensive work inside loops, including API calls, JSON parsing, and regex compilation.
Flag unbounded growth in caches, watchers, or buffers when eviction or limits are missing.
Flag missing pagination or limits on list operations and API endpoints.
Flag secrets or tokens logged in plaintext or hardcoded in source.
Flag API endpoints missing authentication or authorization.
Flag injection vulnerabilities, including SQL injection, command injection, and path traversal.
Flag sensitive data leaked in API responses, WebSocket messages, or logs.
Flag Kubernetes Secrets and Red Hat secrets missing OwnerReferences.

Never commit secrets or keys; use environment variables for sensitive data.

Files:

  • deploy/lightspeed-stack/Containerfile
🔇 Additional comments (1)
deploy/lightspeed-stack/Containerfile (1)

135-137: LGTM!


Walkthrough

The runtime image now sets EXTERNAL_PROVIDERS_DIR to /app-root/providers.d for external provider configuration.

Changes

Runtime configuration

Layer / File(s) Summary
Configure external provider directory
deploy/lightspeed-stack/Containerfile
The runtime image defines EXTERNAL_PROVIDERS_DIR with /app-root/providers.d as its value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: anik120

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes setting EXTERNAL_PROVIDERS_DIR in the image for unified configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed The PR adds only one static ENV declaration and two comments in Containerfile; it adds no loops, API calls, list operations, caches, buffers, or runtime algorithm.
Security And Secret Handling ✅ Passed The only change is a static EXTERNAL_PROVIDERS_DIR path in deploy/lightspeed-stack/Containerfile:137; it adds no secret, endpoint, input handling, logging, or Kubernetes Secret metadata.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jdubrick Jdubrick changed the title fix: set EXTERNAL_PROVIDERS_DIR in image for unified config RHIDP-14083: fix: set EXTERNAL_PROVIDERS_DIR in image for unified config Aug 6, 2026
@Jdubrick

Jdubrick commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

cc @tisnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant