Manual monthly pre-commit update - #309
Merged
Merged
Conversation
Ruff 0.16 changed which lint rules are enabled by default. A couple of the newly enabled rules were simple to enforce, but some of the others are ignored for now to allow `pre-commit` checks to succeed.
eerovaher
commented
Aug 3, 2026
|
|
||
| try: | ||
| from sphinx_astropy.conf.v1 import * # noqa: F403 | ||
| from sphinx_astropy.conf.v1 import * |
Collaborator
Author
There was a problem hiding this comment.
F403 is no longer enforced by default.
eerovaher
commented
Aug 3, 2026
| include_dirs = [np.get_include()] | ||
| libraries = [] | ||
| if int(os.environ.get("PYERFA_USE_SYSTEM_LIBERFA", 0)): | ||
| if int(os.environ.get("PYERFA_USE_SYSTEM_LIBERFA", "0")): |
Collaborator
Author
There was a problem hiding this comment.
PLW1508 (invalid-envvar-default) is now turned on by default, but it was simpler to enforce it than to configure Ruff to ignore it.
avalentino
approved these changes
Aug 4, 2026
Member
|
Thanks a lot @eerovaher |
Collaborator
Author
|
It is not clear to me what I would benefit from having write access to this repository because someone else would still have to review my PRs. However, triage permissions would be useful because then I could add labels to my PRs myself. |
Member
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automatic monthly
pre-commitupdate (#308) failed because Ruff 0.16 changed which lint rules are enabled by default. I added a few (temporary) ignores to the Ruff configuration so thatpre-commitchecks could succeed.Closes #308