add P-line generating path cmd#77
Open
ASLeonard wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know there is not a lot of support for minigraph P-lines (#27) and it would break if a user added any new assemblies, but tools like
vg deconstructappear to perform better with path information than without. We observed ~6% more SVs (and were generally validated against assembly-based calls) when including path information than without. Arguable this may be an issue withvgrather than minigraph not providing P-lines, but that is the current state of tools.This code is based heavily on the
mgutils.js merge, except takes in a sample file and thepaste *bedfrom stdin to create P-lines for each sample based on the paths taken during--call. I haven't really worked with js before, but I believe this is fairly streamlined.This has a few obvious limitations.
But overall we found this useful in our work (https://www.biorxiv.org/content/10.1101/2022.09.17.508368v1, page 4, some of the supplementary figures), so others may too while there is still a lot of graph <-> vcf exchange.
Best,
Alex