Fix dependabot security alert and type errors - #345
Merged
Conversation
$ tsc Done in 7.26s. passes
There was a problem hiding this comment.
Pull request overview
This PR aims to address a Dependabot security alert and clean up TypeScript type errors in the Docusaurus site codebase.
Changes:
- Updates
yarn.lockto introducejs-yaml@^4.1.0(andargparse@^2.0.1) while still retaining ajs-yaml@^3.13.1resolution path. - Updates TypeScript configuration to exclude generated
src-genoutput from typechecking. - Tightens TypeScript typing in the remark placeholder replacement plugin and ref handling in the homepage slider.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Adds js-yaml@4.x / argparse@2.x entries, but still includes js-yaml@3.x via transitive deps. |
tsconfig.json |
Excludes **/src-gen/** from TS processing. |
src/remark/ReplaceTargetLanguagePlaceholder.ts |
Improves plugin typing and uses mdast node types for inserted text nodes. |
src/components/HomepageSlider/index.tsx |
Fixes ref typing and avoids unsafe non-null assertion on current. |
package.json |
Removes the previous js-yaml resolution entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.