fix: Stabilize remote audio listener lifecycle - #19
Merged
Conversation
|
Claude finished @lanyue-llk's task in 2m 0s —— View job 任务清单
Review 结论通过 问题及建议未发现需要阻塞合并的问题。残余风险:
核心改动本身正确:以 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
避免远端参与者列表变化触发音频渲染 effect 重建,从而重复注册监听器、清理并重建音频播放链路,提升连续语音播放稳定性。
Design
Validation
pnpm test✅ passed: 157 tests passed
pnpm lint✅ passed
pnpm build✅ passed
Risk
onnxruntime-web动态依赖警告,无新增构建错误。