This repository was archived by the owner on Jul 24, 2024. It is now read-only.
refactor(number_theory/modular_forms/slash_actions): slash actions are families of distrib_mul_actions - #18932
Open
eric-wieser wants to merge 11 commits into
Open
refactor(number_theory/modular_forms/slash_actions): slash actions are families of distrib_mul_actions#18932eric-wieser wants to merge 11 commits into
distrib_mul_actions#18932eric-wieser wants to merge 11 commits into
Conversation
eric-wieser
added
WIP
eric-wieser
added
the
t-number-theory
eric-wieser
force-pushed
the
eric-wieser/slash_action.redo
branch
from
May 4, 2023 21:34
e769b8a to
25af56d
Compare
github-actions
Bot
removed
the
awaiting-CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the bespoke
slash_action β G α γtypeclass with:Π b : β, distrib_mul_action (slash_act G b) αfor the action itself, whereslash_act G bis a type alias ofmul_opposite(to allow for right actions)smul_comm_class (slash_act G k) γ αfor compatibility with theγactionThis means compatibility with multiple types simultaneously is possible, and that
f ∣[k;γ] Anotation can be discarded.This keeps around
slash_action.map k A fto providef ∣[k] Anotation, but it's now reducibly equal toslash_act.of k A • fIt's not immediately clear that the switch to using
distrib_mul_actionis worth it, but this does at least prove it can be done.