Skip to content

chore: proof mode directory cleanup - #570

Merged
MackieLoeffel merged 28 commits into
leanprover-community:masterfrom
ISTA-PLV:ProofModeFormatting
Aug 7, 2026
Merged

chore: proof mode directory cleanup#570
MackieLoeffel merged 28 commits into
leanprover-community:masterfrom
ISTA-PLV:ProofModeFormatting

Conversation

@alvinylt

@alvinylt alvinylt commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Time to go through the entire ProofMode directory, as most of the IPM tactics have now been ported.

Items from `rocq_tactics.v` that are ported (with `rocq_alias` annotation)
  • tac_accu
  • tac_and_destruct_choice
  • tac_and_destruct
  • tac_and_split
  • tac_apply
  • tac_assert
  • tac_assumption
  • tac_clear
  • tac_combine_as_gives
  • tac_combine_as
  • tac_combine_gives
  • tac_ex_falso
  • tac_exist_destruct
  • tac_exist
  • tac_false_destruct
  • tac_forall_intro
  • tac_forall_revert
  • tac_forall_specialize
  • tac_frame_pure
  • tac_frame
  • tac_impl_intro_drop
  • tac_impl_intro_intuitionistic
  • tac_impl_intro
  • tac_intuitionistic
  • tac_modal_elim
  • tac_modal_intro
  • tac_or_destruct
  • tac_or_l
  • tac_or_r
  • tac_pose_proof
  • tac_pure_intro
  • tac_pure_revert
  • tac_pure
  • tac_revert
  • tac_rewrite_in
  • tac_rewrite
  • tac_sep_split
  • tac_spatial
  • tac_specialize_assert_intuitionistic
  • tac_specialize_assert_pure
  • tac_specialize_assert
  • tac_specialize
  • tac_wand_intro_intuitionistic
  • tac_wand_intro
Items from `rocq_tactics.v` that are ignored (with `rocq_ignore` annotation)
  • affine_env_bi
  • affine_env_nil
  • affine_env_snoc
  • affine_env_spatial
  • combine_seps_as_from_as_gives
  • combine_seps_as_gives_nil
  • combine_seps_as_gives_singleton
  • combine_seps_gives_cons
  • combine_seps_gives_of_envs
  • CombineSepsAs
  • CombineSepsAsGives
  • into_emp_valid_forall
  • into_emp_valid_here
  • into_emp_valid_impl
  • into_emp_valid_proj
  • into_emp_valid_tforall
  • into_laterN_env_sound
  • into_laterN_envs
  • IntoEmpValid
  • tac_assumption_rocq
  • tac_emp_intro
  • tac_eval_in
  • tac_eval
  • tac_löb
  • tac_pose_proof_hyp
  • tac_rename
  • tac_specialize_frame
  • tac_specialize_intuitionistic_helper_done
  • tac_specialize_intuitionistic_helper
  • tac_start
  • tac_stoptac_unlock
  • tac_unlock_emp
  • tac_unlock_True
  • tac_wand_intro_drop
  • transform_intuitionistic_env_nil
  • transform_intuitionistic_env_snoc_not
  • transform_intuitionistic_env_snoc
  • transform_spatial_env_nil
  • transform_spatial_env_snoc_not
  • transform_spatial_env_snoc

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

@MackieLoeffel MackieLoeffel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I looked over the changes and except for two small comments, everything looks fine to me.

Comment thread Iris/Iris/ProofMode/InstancesFrame.lean
Comment thread Iris/Iris/ProofMode/SynthInstance.lean Outdated
@MackieLoeffel

Copy link
Copy Markdown
Collaborator

Great, this is ready to merge from my side!

@MackieLoeffel
MackieLoeffel merged commit b389936 into leanprover-community:master Aug 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants