druntime: Update to wasi-sdk 34 - #5266
Open
QuantumSegfault wants to merge 1 commit into
Open
Conversation
QuantumSegfault
force-pushed
the
update-wasi-sdk-34
branch
from
August 25, 2026 08:16
616fdd3 to
9230900
Compare
thewilsonator
approved these changes
Aug 25, 2026
thewilsonator
approved these changes
Aug 25, 2026
QuantumSegfault
force-pushed
the
update-wasi-sdk-34
branch
4 times, most recently
from
August 25, 2026 16:22
34fce3b to
0a08725
Compare
Contributor
Author
|
All good now. Ready to merge |
kinke
reviewed
Aug 25, 2026
|
|
||
| // Test single-thread (non-shared) use. | ||
| version (WASI) {} // WASI is single-threaded | ||
| else // (& futex wait w/ timeout traps in single-threaded builds) |
Member
There was a problem hiding this comment.
I'm wondering if this shouldn't be handled in the implementation then, as I did for Emscripten.
Contributor
Author
There was a problem hiding this comment.
That probably makes more sense. It's just pthread_cond_timedwait that's problematic for WASI.
I've updated it.
QuantumSegfault
force-pushed
the
update-wasi-sdk-34
branch
from
August 25, 2026 18:33
0a08725 to
7489e89
Compare
| alias uint_fast8_t = ubyte; /// | ||
| alias int_fast16_t = short; /// | ||
| alias uint_fast16_t = ushort; /// | ||
| alias int_fast16_t = int; /// |
Member
There was a problem hiding this comment.
nitpick: maybe add a comment that this highly unintuitive thing is the correct one?
Contributor
Author
There was a problem hiding this comment.
How come? This is far from the only case. In fact, it seems that fast16_t is rarely short. The BSDs, Solaris, Linux, (non-MinGW) Windows all have differing fast16.
Darwin and MinGW being the exceptions, rather than the rule here.
kinke
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the supported version of
wasi-libcto the one distributed bywasi-sdk34.Also updates the version of Wasmtime used by CI to 48.0.1
The diff is smaller than it normally would be, as I incorporated some changes between 33 and 34 when I initially implemented (inadvertently).
Phobos is not yet updated to make use of
flockfile. This will be done alongside other changes needed for WASIp3 later on (i.e. once it actually matters).