refactor(runtime-catalog): index catalog lookups YEF-947 - #476
Merged
Conversation
Collaborator
Author
|
Review verdict: no demonstrated performance need yet. The current catalog contains only 4 runtimes, 10 vendors, and 32 preset models, while this adds multiple indexes and about 80 source lines. A complexity scan proves asymptotics, not user or runtime impact. Please provide a trace or benchmark from a real hot caller; otherwise the smaller linear lookups should stay. |
Yevanchen
force-pushed
the
refactor/yef-947-complexity-hotspots
branch
2 times, most recently
from
August 19, 2026 16:11
3916b52 to
4d43e2b
Compare
Yevanchen
force-pushed
the
refactor/yef-947-complexity-hotspots
branch
from
August 20, 2026 16:14
4d43e2b to
89a8dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Verification
python3 /Users/evanmore/multica_workspaces_desktop-api.multica.ai/baf2a510-889b-4b05-b7c8-c079f5c28938/12b40141/codex-home/skills/complexity-optimizer/scripts/analyze_complexity.py mosoo --format jsonjust fmt-check-path pkgs/runtime-catalogjust test-package @mosoo/runtime-catalogjust tc-package @mosoo/runtime-catalogbun run --filter @mosoo/runtime-catalog lintjust commit-checkjust checkwas attempted. It passed formatting, docs, lint, typecheck, and most tests, then failed inapps/driver/tests/acp-file-system.test.tson a local macOS temp-path mismatch (/tmp/...expected,/private/tmp/...received) plus an extrasourceEventId; this is outside the changed package.Impact
Review
pkgs/runtime-catalog/src/runtime-catalog.ts,pkgs/runtime-catalog/tests/runtime-model-identity-admission.test.ts