Skip to content

OpenOCDDriver: disable default server ports #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ozan956 wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

OpenOCDDriver: disable default server ports #1958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2318,6 +2318,12 @@ OpenOCDDriver
An :any:`OpenOCDDriver` controls *OpenOCD* to bootstrap a target with a
bootloader.

The driver disables OpenOCD's GDB, telnet and TCL server ports. It does not
provide a lifecycle to expose or stop these server interfaces, and disabling
them allows multiple bootstrap operations to run concurrently on one exporter.
Configurations which require a server interface can re-enable it with an
appropriate command before ``init``.

Note that OpenOCD supports specifying USB paths since
`a1b308ab <https://sourceforge.net/p/openocd/code/ci/a1b308ab/>`_ which was released with v0.11.
The OpenOCDDriver passes the resource's USB path.
Expand Down
11 changes: 10 additions & 1 deletion labgrid/driver/openocddriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
from itertools import chain

import attr

from ..factory import target_factory
from ..protocol import BootstrapProtocol
from ..step import step
from ..util.managedfile import ManagedFile
from ..util.helper import processwrapper
from ..util.managedfile import ManagedFile
from .common import Driver


Expand Down Expand Up @@ -55,6 +56,14 @@ def _run_commands(self, commands: list):
cmd = [self.tool]
cmd += chain.from_iterable(("--search", path) for path in self.search)
cmd += self._get_usb_path_cmd()
cmd += [
"--command",
"gdb port disabled",
"--command",
"telnet port disabled",
"--command",
"tcl port disabled",
]

managed_configs = []
for config in self.config:
Expand Down
Loading