fix: run catch blocks only for failed steps - #2760
Open
SanderSimson wants to merge 1 commit into
Open
Conversation
SanderSimson
force-pushed
the
fix/1870-scope-catch-failure-state
branch
from
August 3, 2026 06:38
39a1f83 to
91a1074
Compare
Signed-off-by: Sander Simson <sander.simson@wise.com>
SanderSimson
force-pushed
the
fix/1870-scope-catch-failure-state
branch
from
August 3, 2026 06:40
91a1074 to
ad4b719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes an issue where the
catchblocks from successful steps were executed after an earlier step failed. This polluted test output with diagnostic information from steps that had not failed. Catch execution is now scoped to the current step, while the overall test still remains failed when an operation fails.Related issue
Fixes #1870
Proposed Changes
runStep.tryblock fails.continueOnErrorbehavior.Create the following
test/chainsaw-test.yamland run it with./chainsaw test --no-cluster testto confirm behavior:Checklist
Further Comments