fix(testing): make FakeClient thread-safe - #2759
Open
FirePheonix wants to merge 1 commit into
Open
Conversation
Signed-off-by: Shubham Singh <shubhsoch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
There was a
TODO: not thread safein pkg/client/testing/fake_client.go, and i've done some changes as to what's happening in there..This PR represents a fix of existing test infrastructure behavior by making the
FakeClienttesting utility thread-safe.reviously, when unit tests executed mock client assertions in parallel goroutines, concurrent calls to
FakeClientmethods caused data races while mutating and reading the internal call counter.BEFORE:

Adding mutex synchronization guarantees that parallel test execution remains deterministic, reliable, and free of data races.
Proposed change:

Related issue
Resolves technical debt and addresses the
// TODO: not thread safecomment inpkg/client/testing/fake_client.go.Proposed Changes
sync.RWMutexintoFakeClientinpkg/client/testing/fake_client.go.c.numCallsreads and increments withc.mu.Lock()/c.mu.Unlock()across all client methods (Get,List,Create,Update,Delete,Patch,IsObjectNamespaced,RESTMapper, andSubResource).NumCalls()usingc.mu.RLock()/c.mu.RUnlock().TestFakeClient/Concurrent_calls) inpkg/client/testing/fake_client_test.gothat runs 100 parallel goroutines to verify race-free execution.Checklist
Further Comments
This refactoring cleans up internal test infrastructure debt without changing any public client interfaces or behavior. All existing and new unit tests pass cleanly (
go test -v ./pkg/client/testing/...).