Skip to content

🧪 Harden solution-server test teardown and auth-manager refresh timer #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibolton336 wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −1
Open

🧪 Harden solution-server test teardown and auth-manager refresh timer #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7028cf3
:bug: Fix health poll reconnection churn destabilizing infra tests
ibolton336 Jul 8, 2026
d8e6742
:bug: Add kai-api health check, retry on 421, fix timer overflow in t…
ibolton336 Jul 8, 2026
5b670dc
:seedling: Fix infra-test 421 at the source; drop churn-hypothesis ch…
ibolton336 Jul 9, 2026
342c870
:seedling: Revert kai-api 421 CI workaround; fix belongs in kai
ibolton336 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/tests/solution-server/analysis-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ test.describe.serial(
});

test.afterAll(async () => {
await vsCode.closeVSCode();
await vsCode?.closeVSCode();
});

/**
Expand Down
6 changes: 6 additions & 0 deletions tests/solution-server-auth/authentication-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ export class AuthenticationManager {
}

const timeUntilRefresh = this.tokenExpiresAt - Date.now();
// Node's setTimeout stores its delay in a 32-bit signed int (max ~24.8 days).
// Tokens with multi-year lifespans overflow to 1ms, spinning the refresh loop.
const MAX_TIMER_MS = 2 ** 31 - 1;
if (timeUntilRefresh > MAX_TIMER_MS) {
return;
}
this.refreshTimer = setTimeout(
async () => {
try {
Expand Down
Loading