Skip to content

repair the public/storage symlink shipped in the release tarball #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phanan merged 1 commit into from
Aug 10, 2026
Merged

repair the public/storage symlink shipped in the release tarball #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ RUN a2enmod rewrite
# Copy the downloaded release
RUN cp -R /tmp/koel/. /var/www/html \
&& mv /var/www/html/public/manifest.json.example /var/www/html/public/manifest.json \
# The release tarball ships public/storage as an absolute symlink into the path the
# release runner built it at, which resolves nowhere here and leaves koel unable to read
# or write uploaded images. Replace it with a relative link to the same target.
&& ln -sfn ../storage/app/public /var/www/html/public/storage \
Comment on lines +105 to +108

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

Use the required git clone source for KOEL_VERSION_REF.

The Dockerfile still downloads a release tarball at Line 8. It does not clone Koel at the ref declared by ARG KOEL_VERSION_REF.

Change the source step to clone KOEL_VERSION_REF, or update the guideline if release tarballs are intentional.

As per coding guidelines: “The Dockerfile must use ARG KOEL_VERSION_REF=... as the git ref to clone the koel app at the specified version.”

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 105 - 108, The Dockerfile source step must clone the
Koel repository at the declared KOEL_VERSION_REF instead of downloading a
release tarball. Update the initial application-fetch command to use ARG
KOEL_VERSION_REF as the git ref, while preserving the existing build layout and
subsequent setup steps.

Source: Coding guidelines

&& chown -R www-data:www-data /var/www/html

# Volumes for the music files, image storage, and search index
Expand Down
10 changes: 10 additions & 0 deletions goss.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,16 @@ file:
owner: www-data
group: www-data
filetype: directory
/var/www/html/storage/app/public/images:
exists: true
mode: "0755"
owner: www-data
group: www-data
filetype: directory
/var/www/html/public/storage:
exists: true
filetype: symlink
linked-to: ../storage/app/public
package:
ffmpeg:
installed: true
Expand Down
Loading