[UI] fix: enhance supporters logos for dark mode compatibility and remove duplicate link in support - #335
Conversation
…ers component Signed-off-by: devGP7 <gauravpatil232005@gmail.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR updates supporter logo rendering to improve dark-mode visuals and accessibility by switching to SVG assets and theme-aware image selection, and by removing an empty link element.
Changes:
- Added light/dark SVG variants for Huawei and OpenEuler logos.
- Updated the Supporters component to use Docusaurus
ThemedImagefor theme-based logo switching. - Removed forced white background/border styling around logos and deleted an empty
<Link>.
Reviewed changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| static/img/supporters/openEuler.svg | Replaces the existing OpenEuler asset with a formatted SVG variant for light mode. |
| static/img/supporters/openEuler-dark.svg | Adds a dark-mode-specific OpenEuler SVG with white fills for non-brand elements. |
| static/img/supporters/huawei.svg | Adds an SVG Huawei logo for light mode. |
| static/img/supporters/huawei-dark.svg | Adds a dark-mode Huawei SVG variant with white typography. |
| src/components/Supporters/index.scss | Removes hardcoded white background/border so logos blend with theme backgrounds. |
| src/components/Supporters/index.js | Uses ThemedImage + new assets and removes an empty <Link> element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ThemedImage | ||
| alt={item.name} | ||
| sources={{ | ||
| light: useBaseUrl(item.img_src), | ||
| dark: useBaseUrl(item.img_src_dark || item.img_src), | ||
| }} | ||
| /> |
| } | ||
|
|
New Images/logos are compatible with both themes and improve visual aspect of website |
Problem:
Solution:
3)Removed the forced white backgrounds and borders from the .imgContainer in the SCSS file, allowing the logos to blend naturally into the website's background.