feat(assistant): activate governed skills - #304
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds governed Skill discovery, exact-release activation, bounded resource reads, bounded model tool loops, and streamed Skill activity updates across core, gateway, API, and web layers. ChangesAgentic Skill flow
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant AssistantService
participant SpringAiChatModelAdapter
participant AssistantSkillToolCallbacks
participant SkillRuntimeService
participant AssistantController
AssistantService->>SpringAiChatModelAdapter: start actor-aware assistant stream
SpringAiChatModelAdapter->>AssistantSkillToolCallbacks: invoke bounded Skill tool
AssistantSkillToolCallbacks->>SkillRuntimeService: search, activate, or read resource
SkillRuntimeService-->>AssistantSkillToolCallbacks: return authorized Skill data
AssistantSkillToolCallbacks-->>SpringAiChatModelAdapter: return result and lifecycle activity
SpringAiChatModelAdapter-->>AssistantService: stream text and activities
AssistantService-->>AssistantController: return AssistantTurn
AssistantController-->>AssistantController: merge text and activity stream parts
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format Release preview
Changelogs in this PR
Run Managed by Tegami. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
integrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/SpringAiChatModelAdapter.java (1)
282-306: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winSeparate the Assistant-specific memory-client cache.
memoryClient()andassistantMemoryClient()store both Assistant memory clients underModelKey(organizationId, ASSISTANT_CHAT, route, gateway).computeIfAbsentcaches the first builder configuration for both paths.If
memoryClient()creates the entry first, the fallback Assistant path reusesresolve(...)and does not disable automatic tool-advisor registration. IfassistantMemoryClient()creates the entry first, the agent memory path reusesresolveAssistant(...)and Assistant-only configuration. Use a separate cache forassistantMemoryClient(), or include the client mode inModelKey, and evict superseded entries from both caches. Add a regression test that invokes both memory-code paths in each order.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/SpringAiChatModelAdapter.java` around lines 282 - 306, Separate the cache used by assistantMemoryClient() from memoryClient(), or extend ModelKey with a client-mode discriminator, so each path retains its own model resolver and advisor configuration. Update evictSuperseded() to remove superseded entries from both caches, then add regression coverage invoking memoryClient() and assistantMemoryClient() in both creation orders and verifying each configuration remains distinct.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@integrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/SpringAiChatModelAdapter.java`:
- Around line 282-306: Separate the cache used by assistantMemoryClient() from
memoryClient(), or extend ModelKey with a client-mode discriminator, so each
path retains its own model resolver and advisor configuration. Update
evictSuperseded() to remove superseded entries from both caches, then add
regression coverage invoking memoryClient() and assistantMemoryClient() in both
creation orders and verifying each configuration remains distinct.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2a31e61e-59d2-451e-a092-c78fe4d1e6eb
⛔ Files ignored due to path filters (10)
docs/increments/completed/2026-08-05-agentic-skill-beta/challenge-brief.mdis excluded by!docs/**docs/increments/completed/2026-08-05-agentic-skill-beta/challenge-verdict.mdis excluded by!docs/**docs/increments/completed/2026-08-05-agentic-skill-beta/design.mdis excluded by!docs/**docs/increments/completed/2026-08-05-agentic-skill-beta/plan.mdis excluded by!docs/**docs/increments/completed/2026-08-05-agentic-skill-beta/verification.mdis excluded by!docs/**docs/roadmap.mdis excluded by!docs/**docs/specs/domains/asset-registry.mdis excluded by!docs/**docs/specs/domains/assistant-and-mcp.mdis excluded by!docs/**docs/tests/domains/asset-registry.mdis excluded by!docs/**docs/tests/domains/assistant-and-mcp.mdis excluded by!docs/**
📒 Files selected for processing (30)
.tegami/2026-08-05-agentic-skill-beta.mdARCHITECTURE.mdapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantController.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantStreamPart.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javaapps/api/src/test/java/com/orgmemory/api/assistant/UiMessageStreamTests.javaapps/docs/content/docs/getting-started/first-governed-journey.mdxapps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/web/src/features/assistant/assistant-activity.tsapps/web/src/features/assistant/components/assistant-page.test.tsapps/web/src/features/assistant/components/assistant-page.tsxapps/web/test/e2e/assistant-pipeline.spec.tscore/src/main/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryService.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeService.javacore/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseDeliveryQuery.javacore/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseSummary.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAgentActivity.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAgentModelPort.javacore/src/main/java/com/orgmemory/core/assistant/AssistantService.javacore/src/main/java/com/orgmemory/core/assistant/AssistantTurn.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/test/java/com/orgmemory/core/ai/AssistantAgentServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeServiceTests.javaintegrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacks.javaintegrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/SpringAiChatModelAdapter.javaintegrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacksTests.javaintegrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolLoopTests.java
📜 Review details
🧰 Additional context used
📓 Path-based instructions (10)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Extend the established OrgMemory product shell, design tokens, shadcn/Radix primitives, and existing layout patterns; do not introduce a separate visual system in the web application.
Generate ordinary REST clients fromcontracts/openapi.jsonusing Hey API.
Use TanStack Query for server state, TanStack Router for navigation, and limit Zustand to durable or high-frequency UI state.
Preserve keyboard accessibility, light/dark theme support, loading and error states, and responsive behavior in the web application.
Files:
apps/web/test/e2e/assistant-pipeline.spec.tsapps/web/src/features/assistant/assistant-activity.tsapps/web/src/features/assistant/components/assistant-page.test.tsapps/web/src/features/assistant/components/assistant-page.tsx
apps/web/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Preserve the existing browser test suite when changing the web application.
Files:
apps/web/test/e2e/assistant-pipeline.spec.tsapps/web/src/features/assistant/components/assistant-page.test.ts
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Treat the repository and runtime evidence as the engineering system of record; do not treat chat or Northstar as authoritative.
Before changing a domain, read its specification, test-coverage document, and applicable decision filenames.
Material decisions about domain boundaries, authorization, persistence, publication, concurrency, cache isolation, parity scope, or deployment require an independent architecture challenge and documented alternatives before implementation.
Do not use completed increment documents as the source for current behavior; use them only for history or archaeology.
Before using unfamiliar Spring Boot, Spring Modulith, Spring AI, Gradle, React, Vite, Tailwind, TypeScript, Next.js, or Fumadocs APIs, consult current official documentation, Context7, and the relevant verification skill.
Readdocs/guidelines/agent-safety.mdbefore retrieval, AI, MCP, permission, upload, graph, or export work; never commit secrets or customer data.
Keepddl-auto=validateand pair every persisted-model change with a Flyway migration.
Use the testing harness; a terminating clean test is the JVM context gate, andbootRunis not verification.
Files:
apps/web/test/e2e/assistant-pipeline.spec.tsapps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javaintegrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolLoopTests.javaapps/api/src/test/java/com/orgmemory/api/assistant/UiMessageStreamTests.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantStreamPart.javacore/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseDeliveryQuery.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAgentModelPort.javacore/src/main/java/com/orgmemory/core/assistant/AssistantTurn.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAgentActivity.javaintegrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacksTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseSummary.javacore/src/test/java/com/orgmemory/core/ai/AssistantAgentServiceTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javaapps/web/src/features/assistant/assistant-activity.tsintegrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacks.javaapps/web/src/features/assistant/components/assistant-page.test.tscore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryService.javacore/src/main/java/com/orgmemory/core/assistant/AssistantService.javaapps/docs/content/docs/getting-started/first-governed-journey.mdxintegrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/SpringAiChatModelAdapter.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantController.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeService.javaARCHITECTURE.mdcore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeServiceTests.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.javaapps/web/src/features/assistant/components/assistant-page.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Frontend changes must pass lint, typecheck, tests, and a production build; perform browser verification when the flow warrants it.
Files:
apps/web/test/e2e/assistant-pipeline.spec.tsapps/web/src/features/assistant/assistant-activity.tsapps/web/src/features/assistant/components/assistant-page.test.tsapps/web/src/features/assistant/components/assistant-page.tsx
apps/docs/content/docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (apps/docs/CLAUDE.md)
apps/docs/content/docs/**/*.{md,mdx}: Public prose must live only inapps/docs/content/docs; internal engineering documents are source evidence, not publication input.
sourceRefsis build-time traceability metadata and must never be rendered in published content.
Draft pages must remain excluded unlessDOCS_INCLUDE_DRAFTS=trueis set for a local or controlled preview.
Files:
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/docs/content/docs/getting-started/first-governed-journey.mdx
apps/docs/content/docs/**/*.mdx
📄 CodeRabbit inference engine (apps/docs/CLAUDE.md)
Use
index.mdxfor a section root and<slug>.mdxfor a named English page; add Vietnamese pages individually as adjacentindex.vi.mdxor<slug>.vi.mdxfiles, using the/vi/docs/...route.
Files:
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/docs/content/docs/getting-started/first-governed-journey.mdx
apps/docs/content/docs/**/*.vi.mdx
📄 CodeRabbit inference engine (apps/docs/CLAUDE.md)
Vietnamese routes must visibly fall back to the reviewed English page until the matching
.vi.mdxexists; a fallback route is not a completed translation.
Files:
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdx
**/*.java
📄 CodeRabbit inference engine (AGENTS.md)
Apply IDE inspection only to edited backend Java files.
Files:
apps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javaintegrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolLoopTests.javaapps/api/src/test/java/com/orgmemory/api/assistant/UiMessageStreamTests.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantStreamPart.javacore/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseDeliveryQuery.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAgentModelPort.javacore/src/main/java/com/orgmemory/core/assistant/AssistantTurn.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAgentActivity.javaintegrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacksTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseSummary.javacore/src/test/java/com/orgmemory/core/ai/AssistantAgentServiceTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javaintegrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacks.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryService.javacore/src/main/java/com/orgmemory/core/assistant/AssistantService.javaintegrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/SpringAiChatModelAdapter.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantController.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeService.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeServiceTests.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.java
apps/api/src/main/java/**/*.java
⚙️ CodeRabbit configuration file
apps/api/src/main/java/**/*.java: Enforce the browser-BFF and resource-server boundaries. Authentication
must resolve an active internal actor through the explicit issuer and
subject binding. Reject identity, tenant, roles, or permissions supplied
by request payloads, JWT email, or untrusted JWT role claims.
Files:
apps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantStreamPart.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantController.java
apps/web/src/**/*.{ts,tsx}
⚙️ CodeRabbit configuration file
apps/web/src/**/*.{ts,tsx}: OAuth access and refresh tokens must never enter browser JavaScript or
browser storage. Use the HttpOnly BFF session, CSRF-protected mutations,
generated Hey API data clients, accessible states, and both light and
dark themes. Handwritten transport is reserved for documented protocol
flows such as navigation redirects and streaming.
Files:
apps/web/src/features/assistant/assistant-activity.tsapps/web/src/features/assistant/components/assistant-page.test.tsapps/web/src/features/assistant/components/assistant-page.tsx
🧠 Learnings (5)
📚 Learning: 2026-07-28T20:06:14.930Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 112
File: apps/docs/content/docs/developers/api-reference/administration.mdx:11-11
Timestamp: 2026-07-28T20:06:14.930Z
Learning: In OrgMemory public documentation MDX files, ensure any `lastReviewed` dates are set using the repository project timezone `Asia/Bangkok`, not the reviewer’s local timezone or the runtime/build timezone. When generating or updating API-reference pages, intentionally use the exact same `lastReviewed` date convention as the authored public documentation pages to keep timestamps consistent across both sources.
Applied to files:
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/docs/content/docs/getting-started/first-governed-journey.mdx
📚 Learning: 2026-07-28T20:06:15.064Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 112
File: apps/docs/content/docs/developers/api-reference/authentication.mdx:12-12
Timestamp: 2026-07-28T20:06:15.064Z
Learning: In OrgMemory docs/tests that describe date-based review checks, treat the project timezone as Asia/Bangkok for all “date” comparisons/validations. Do not assume UTC when interpreting or validating fields like `lastReviewed`. For example, `lastReviewed: '2026-07-29'` should be considered valid when the effective “current date” in Asia/Bangkok is July 29, 2026 (not merely when the UTC date matches).
Applied to files:
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/docs/content/docs/getting-started/first-governed-journey.mdx
📚 Learning: 2026-07-30T06:46:08.031Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 144
File: apps/docs/public-content.manifest.json:13-67
Timestamp: 2026-07-30T06:46:08.031Z
Learning: For the Fumadocs docs portal under apps/docs, follow the expected MDX filename conventions that drive section-root vs named-page routing. Use `index.mdx` for English section-root pages and `<slug>.mdx` for named pages. For Vietnamese, use adjacent locale-suffixed files: `index.vi.mdx` for section roots and `<slug>.vi.mdx` for named pages. Do not require or enforce a `page.mdx` filename; doing so would change/break the intended section-root route structure.
Applied to files:
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdxapps/docs/content/docs/getting-started/first-governed-journey.mdx
📚 Learning: 2026-07-26T05:46:47.443Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 61
File: apps/mcp/src/main/java/com/orgmemory/mcp/McpSecurityConfiguration.java:50-52
Timestamp: 2026-07-26T05:46:47.443Z
Learning: In OrgMemory, treat the `apps/mcp` and `apps/api` as independent protocol adapter modules. When adjusting OAuth/wire-level scopes, do not introduce a shared Java constant or create a code dependency from `apps/mcp` to `apps/api` solely to deduplicate scope values. Instead, keep OAuth/scope constants adapter-local (e.g., in the relevant adapter/security configuration classes) and ensure cross-adapter consistency via automated realm/OAuth/authorization tests, rather than via shared wiring-level constants or cross-module references.
Applied to files:
apps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantStreamPart.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantController.java
📚 Learning: 2026-08-05T09:53:56.596Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 300
File: .tegami/2026-08-05-retrieval-recall-observations.md:7-7
Timestamp: 2026-08-05T09:53:56.596Z
Learning: For Tegami release fragments in `.tegami/*.md`, do not require a top-level H1 solely to satisfy markdownlint MD041. These fragments must instead contain an approved level-two public changelog section, such as `## Improvements`, as enforced by `scripts/check-release.mjs`; the generated release output contract prevents adding a second page-level H1.
Applied to files:
.tegami/2026-08-05-agentic-skill-beta.md
🪛 ast-grep (0.45.0)
integrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacks.java
[warning] 71-71: Avoid LDAP injections
Context: skills.search(actor, query, limit)
Note: [CWE-90] Improper Neutralization of Special Elements used in an LDAP Query ('LDAP Injection'). Security best practice.
(ldap-injection-java)
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeService.java
[warning] 45-45: Avoid LDAP injections
Context: deliveries.search(actor, query, limit)
Note: [CWE-90] Improper Neutralization of Special Elements used in an LDAP Query ('LDAP Injection'). Security best practice.
(ldap-injection-java)
🪛 markdownlint-cli2 (0.23.2)
.tegami/2026-08-05-agentic-skill-beta.md
[warning] 7-7: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🔇 Additional comments (19)
ARCHITECTURE.md (1)
220-225: LGTM!Also applies to: 420-428
core/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseSummary.java (1)
1-15: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skilldelivery/SkillReleaseDeliveryQuery.java (1)
4-10: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryService.java (1)
12-16: LGTM!Also applies to: 48-72, 179-188
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeService.java (1)
1-221: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.java (1)
24-74: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeServiceTests.java (1)
1-228: LGTM!.tegami/2026-08-05-agentic-skill-beta.md (1)
1-12: LGTM!apps/docs/content/docs/getting-started/first-governed-journey.mdx (1)
13-20: LGTM!Also applies to: 98-103
apps/docs/content/docs/getting-started/first-governed-journey.vi.mdx (1)
13-20: LGTM!Also applies to: 102-107
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeOperations.java (1)
10-44: 📐 Maintainability & Code QualityRun the required backend verification before merge.
Attach repository or CI evidence for a clean JVM test-harness run and IDE inspection of these edited backend Java files.
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRuntimeOperations.java#L10-L44: include the new Skill runtime contract in IDE inspection.core/src/main/java/com/orgmemory/core/assistant/AssistantAgentActivity.java#L4-L19: include the activity contract in IDE inspection.core/src/main/java/com/orgmemory/core/assistant/AssistantAgentModelPort.java#L12-L18: include the agent model boundary in IDE inspection.core/src/main/java/com/orgmemory/core/assistant/AssistantTurn.java#L9-L16,L33-L35: include the reactive turn contract in IDE inspection.core/src/main/java/com/orgmemory/core/assistant/AssistantService.java#L190-L204,L237-L247: include the agent routing and activity-sink path in IDE inspection and the clean test gate.core/src/test/java/com/orgmemory/core/ai/AssistantAgentServiceTests.java#L30-L110: execute this coverage through the clean test gate.apps/api/src/main/java/com/orgmemory/api/assistant/AssistantController.java#L404-L415,L455-L460: include SSE activity mapping in IDE inspection and the clean test gate.apps/api/src/main/java/com/orgmemory/api/assistant/AssistantStreamPart.java#L18-L27: include the stream protocol enum changes in IDE inspection.apps/api/src/test/java/com/orgmemory/api/assistant/UiMessageStreamTests.java#L56-L74: execute SSE encoding coverage through the clean test gate.As per coding guidelines, “Apply IDE inspection only to edited backend Java files” and “Use the testing harness; a terminating clean test is the JVM context gate, and
bootRunis not verification.”Source: Coding guidelines
apps/web/src/features/assistant/assistant-activity.ts (1)
1-38: 📐 Maintainability & Code QualityVerify the changed Assistant activity flow in the web pipeline.
Run lint, typecheck, unit tests, the production build, and the existing browser suite. Verify Skill activity states in light and dark themes and with keyboard-only navigation.
As per coding guidelines, “Frontend changes must pass lint, typecheck, tests, and a production build; perform browser verification when the flow warrants it.”
Source: Coding guidelines
core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java (1)
1361-1365: LGTM!Also applies to: 1410-1414, 1467-1486
integrations/ai-model-gateways/src/main/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacks.java (1)
26-180: LGTM!integrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolCallbacksTests.java (1)
35-137: LGTM!integrations/ai-model-gateways/src/test/java/com/orgmemory/integrations/ai/gateway/AssistantSkillToolLoopTests.java (1)
30-153: LGTM!apps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.java (1)
5-5: LGTM!Also applies to: 81-94
apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.java (1)
20-20: LGTM!Also applies to: 204-205
apps/web/src/features/assistant/components/assistant-page.tsx (1)
224-231: 📐 Maintainability & Code QualityVerify the modified Assistant activity flow in the frontend pipeline.
No repository or pipeline result is supplied in this review context. Do not use the PR summary as verification evidence.
apps/web/src/features/assistant/components/assistant-page.tsx#L224-L231: verify that active, complete, and failed Skill frames render without breaking the Assistant flow.apps/web/src/features/assistant/components/assistant-page.test.ts#L6-L23: run the unit test suite and typecheck.apps/web/test/e2e/assistant-pipeline.spec.ts#L797-L809: run the Playwright Assistant flow, including streamed Skill activity frames.Run lint, typecheck, unit tests, a production build, and browser verification.
As per coding guidelines, “Frontend changes must pass lint, typecheck, tests, and a production build; perform browser verification when the flow warrants it,” and “Treat the repository and runtime evidence as the engineering system of record.”
Source: Coding guidelines
|
Addressed the cache-isolation finding in e2fc879: Assistant agent memory clients now use a dedicated cache, superseded profile eviction covers all three client caches, and regression coverage exercises both general-first and assistant-first creation orders. Verified with the focused regression tests and the full ai-model-gateways test task. |
1 participant
Summary
Deliver the Agentic Skill Beta as a bounded, read-only extension of the existing governed Assistant:
SKILL.mdinstructions and read bounded verified UTF-8 resources;allowed-toolsdescriptive, and never execute package scripts, binaries, shell commands, or arbitrary code.The Asset Registry remains the single Skill registry. The architecture challenge, completed increment, current specs, coverage matrices, and EN/VI product guidance are included.
Verification
Evidence:
./gradlew.bat --no-daemon clean test— 108 actionable tasks, successful.pnpm release:check— Tegami release management checks passed.git diff --check— passed.JetBrains IDE inspection was unavailable in this tool session; clean Gradle compilation/tests and the mechanical frontend/docs gates were used as the documented fallback.
Documentation impact
apps/docs, or this change has no reader-visible product/API/UI/deployment behavior.The remaining beta boundary is explicit: empty authorized Knowledge retrieval still stops before the model and Skill tools. Sandboxed execution, autonomous jobs, and dynamic tool grants remain out of scope.
Summary by CodeRabbit
New Features
Documentation
Tests