refactor(knowledge): close ACL module

[kl3inIT]

Summary

• close the knowledge.acl Spring Modulith nested module
• restrict its outgoing dependencies to organization, permission, shared, and shared::error
• pin the closed state and exact four-entry allowlist in the Modulith regression suite

Architecture

This completes ACL closure after PR #213 replaced its remaining sibling implementation edges, following the existing Claude Fable 5 architecture verdict.

Verification

• focused ACL package and ModulithVerificationTests (25s)
• :core:test (1m08s)
• python scripts/check_docs.py (417 Markdown files, 8 mirrored pairs)
• pnpm release:check under Node 24.15 (37 tests)
• terminating gradlew clean test (5m07s, 99 tasks)
• zero ACL sibling imports; 4 changed paths

Summary by CodeRabbit

• Refactor

  • Strengthened the Knowledge access-control module’s boundaries to improve consistency and maintainability.
  • Restricted integrations to approved organization, permission, and shared services.

• Documentation

  • Added release documentation describing the updated access-control module boundary and supported integrations.

• Tests

  • Updated verification coverage to confirm the module’s permitted integrations remain enforced.

[coderabbitai]

Warning

Review limit reached

@kl3inIT, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 24f537c1-9ce2-4b41-bf07-cb07bb466ac0

📥 Commits

Reviewing files that changed from the base of the PR and between 4255c60 and 0692ce8.

⛔ Files ignored due to path filters (1)

• docs/increments/active/2026-07-31-spring-modulith-package-refactor/plan.md is excluded by !docs/**

📒 Files selected for processing (1)

• .tegami/close-acl-module.md

📝 Walkthrough

Walkthrough

The Knowledge ACL module is now closed. Its outgoing dependencies are limited to organization, permission, shared, and shared::error. Modulith verification and release documentation reflect the new boundary.

Changes

Knowledge ACL module boundary

Layer / File(s)	Summary
Close ACL boundary and verify dependencies core/src/main/java/com/orgmemory/core/knowledge/acl/package-info.java, core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java, .tegami/close-acl-module.md	The module declaration changes to CLOSED with four allowed dependencies. The verification test checks the normalized allowlist. Release documentation records the boundary change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• kl3inIT/OrgMemory#181: Both changes modify the ACL module declaration and verification test.
• kl3inIT/OrgMemory#208: Both changes formalize the ACL module boundary and dependency allowlist.
• kl3inIT/OrgMemory#210: Both changes close a Knowledge module with an explicit dependency allowlist.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the main change: closing the knowledge ACL module.
Description check	✅ Passed	The description covers the change, architecture context, verification evidence, and documentation checks, but it omits the explicit Documentation impact section.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/modulith-close-acl

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Tegami

This repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under .tegami/ before merging.

Create a changelog → · Changelog format

Release preview

Package	Bump	Version
orgmemory	minor	0.1.1 → 0.2.0

Changelogs in this PR

Changelog	Title
close-acl-module.md	Close the Knowledge ACL module boundary
close-acl-module.md	Improvements

Run pnpm run tegami locally to create a changelog interactively.

_{Managed by Tegami.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tegami/close-acl-module.md:
- Around line 11-13: Update the ACL closure note to list the complete dependency
allowlist explicitly: organization, permission, shared, and shared::error.
Replace the vague “shared foundations” wording while preserving the existing
description of the closed public API.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b48d9ad4-0f2c-4c97-b062-30d851853dc5

📥 Commits

Reviewing files that changed from the base of the PR and between 6e8e5fe and 4255c60.

⛔ Files ignored due to path filters (1)

• docs/increments/active/2026-07-31-spring-modulith-package-refactor/plan.md is excluded by !docs/**

📒 Files selected for processing (3)

• .tegami/close-acl-module.md
• core/src/main/java/com/orgmemory/core/knowledge/acl/package-info.java
• core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java

📜 Review details

⏰ Context from checks skipped due to timeout. (1)

• GitHub Check: Backend · Java 25

🧰 Additional context used

📓 Path-based instructions (3)

**/*

📄 CodeRabbit inference engine (AGENTS.md)

**/*: Treat the repository and runtime evidence as the engineering system of record; do not treat chat or Northstar as authoritative.
Before changing a domain, read its specification, test-coverage document, and applicable decision filenames.
Material decisions about domain boundaries, authorization, persistence, publication, concurrency, cache isolation, parity scope, or deployment require an independent architecture challenge and documented alternatives before implementation.
Do not use completed increment documents as the source for current behavior; use them only for history or archaeology.
Before using unfamiliar Spring Boot, Spring Modulith, Spring AI, Gradle, React, Vite, Tailwind, TypeScript, Next.js, or Fumadocs APIs, consult current official documentation, Context7, and the relevant verification skill.
Read docs/guidelines/agent-safety.md before retrieval, AI, MCP, permission, upload, graph, or export work; never commit secrets or customer data.
Keep ddl-auto=validate and pair every persisted-model change with a Flyway migration.
Use the testing harness; a terminating clean test is the JVM context gate, and bootRun is not verification.

Files:

• core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java
• core/src/main/java/com/orgmemory/core/knowledge/acl/package-info.java

**/*.java

📄 CodeRabbit inference engine (AGENTS.md)

Apply IDE inspection only to edited backend Java files.

Files:

• core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java
• core/src/main/java/com/orgmemory/core/knowledge/acl/package-info.java

core/src/main/java/com/orgmemory/core/{authorization,knowledge,permission}/**/*.java

⚙️ CodeRabbit configuration file

core/src/main/java/com/orgmemory/core/{authorization,knowledge,permission}/**/*.java: Treat PostgreSQL ACL evidence as canonical and OpenFGA as the relationship
authorization decision point. Authorization must fail closed. Filtering
must happen before ranking, LIMIT, graph traversal, answer generation,
export, and citation rendering. Flag metadata or timing leak paths.

Files:

• core/src/main/java/com/orgmemory/core/knowledge/acl/package-info.java

🔇 Additional comments (3)

core/src/main/java/com/orgmemory/core/knowledge/acl/package-info.java (1)

8-18: LGTM!

core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java (1)

134-148: LGTM!

.tegami/close-acl-module.md (1)

1-10: LGTM!

Also applies to: 14-16