refactor(knowledge): extract graph module - #190
Merged
Conversation
📝 WalkthroughWalkthroughThe change moves knowledge-graph types into ChangesKnowledge graph package boundary
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…wledge-graph # Conflicts: # core/src/main/java/com/orgmemory/core/knowledge/ResolvedKnowledgeEvidenceScope.java
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format Release preview
Changelogs in this PR
Run Managed by Tegami. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core/src/main/java/com/orgmemory/core/knowledge/asset/KnowledgeChunkProjectionStore.java`:
- Line 4: Address the cross-module dependency exposed by
KnowledgeChunkProjectionStore.loadActive(...) and GraphIndexingCoordinator
injection: either make the contract graph-neutral by removing GraphIndexChunk
from the asset-facing API, or document an architecture challenge decision
recording this dependency, its rationale, and considered alternatives.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 35996b7e-103a-4f9e-ac0a-7c106f85fac1
⛔ Files ignored due to path filters (2)
docs/increments/active/2026-07-31-spring-modulith-package-refactor/design.mdis excluded by!docs/**docs/increments/active/2026-07-31-spring-modulith-package-refactor/plan.mdis excluded by!docs/**
📒 Files selected for processing (52)
apps/api/src/main/java/com/orgmemory/api/OrgMemoryApiApplication.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.javaapps/api/src/test/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementControllerTests.javaapps/worker/src/main/java/com/orgmemory/worker/OrgMemoryWorkerApplication.javaapps/worker/src/main/java/com/orgmemory/worker/graph/GraphIndexingProcessor.javaapps/worker/src/main/java/com/orgmemory/worker/graph/GraphPublicationCommitter.javaapps/worker/src/test/java/com/orgmemory/worker/graph/GraphIndexingProcessorTests.javaapps/worker/src/test/java/com/orgmemory/worker/graph/GraphPublicationCommitterTests.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfile.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfileRepository.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeResolver.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeUnavailableException.javacore/src/main/java/com/orgmemory/core/knowledge/ResolvedKnowledgeEvidenceScope.javacore/src/main/java/com/orgmemory/core/knowledge/SecureKnowledgeRetrievalStore.javacore/src/main/java/com/orgmemory/core/knowledge/SecureRetrievalCandidate.javacore/src/main/java/com/orgmemory/core/knowledge/asset/KnowledgeChunkProjectionStore.javacore/src/main/java/com/orgmemory/core/knowledge/connector/ConnectorSourceRevisionCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/graph/ClaimedGraphIndex.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphExplorerProperties.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexChunk.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJob.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobQueue.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobRepository.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobStatus.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobView.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingStoppedException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRef.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRegistry.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRepository.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileResolver.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProperties.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationCommand.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerConfiguration.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphView.javacore/src/main/java/com/orgmemory/core/knowledge/graph/PersistedGraphProcessingProfile.javacore/src/main/java/com/orgmemory/core/knowledge/graph/package-info.javacore/src/main/java/com/orgmemory/core/knowledge/sourceledger/SourceIngestionCoordinator.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/test/java/com/orgmemory/core/knowledge/CanonicalHybridKnowledgeSearchTests.javacore/src/test/java/com/orgmemory/core/knowledge/GraphRagKnowledgeRetrievalServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinatorTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportServiceTests.java
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Web · Node 24
- GitHub Check: Backend · Java 25
🧰 Additional context used
📓 Path-based instructions (4)
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Treat the repository and runtime evidence as the engineering system of record; do not treat chat or Northstar as authoritative.
Before changing a domain, read its specification, test-coverage document, and applicable decision filenames.
Material decisions about domain boundaries, authorization, persistence, publication, concurrency, cache isolation, parity scope, or deployment require an independent architecture challenge and documented alternatives before implementation.
Do not use completed increment documents as the source for current behavior; use them only for history or archaeology.
Before using unfamiliar Spring Boot, Spring Modulith, Spring AI, Gradle, React, Vite, Tailwind, TypeScript, Next.js, or Fumadocs APIs, consult current official documentation, Context7, and the relevant verification skill.
Readdocs/guidelines/agent-safety.mdbefore retrieval, AI, MCP, permission, upload, graph, or export work; never commit secrets or customer data.
Keepddl-auto=validateand pair every persisted-model change with a Flyway migration.
Use the testing harness; a terminating clean test is the JVM context gate, andbootRunis not verification.
Files:
apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.javacore/src/main/java/com/orgmemory/core/knowledge/graph/package-info.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfileRepository.javaapps/api/src/test/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementControllerTests.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfile.javaapps/worker/src/main/java/com/orgmemory/worker/OrgMemoryWorkerApplication.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportServiceTests.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.javacore/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinatorTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobStatus.javacore/src/main/java/com/orgmemory/core/knowledge/SecureRetrievalCandidate.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleServiceTests.javaapps/worker/src/test/java/com/orgmemory/worker/graph/GraphIndexingProcessorTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobView.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJob.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileResolver.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.javacore/src/main/java/com/orgmemory/core/knowledge/ResolvedKnowledgeEvidenceScope.javaapps/worker/src/main/java/com/orgmemory/worker/graph/GraphPublicationCommitter.javaapps/worker/src/test/java/com/orgmemory/worker/graph/GraphPublicationCommitterTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexChunk.javaapps/worker/src/main/java/com/orgmemory/worker/graph/GraphIndexingProcessor.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProperties.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphExplorerProperties.javaapps/api/src/main/java/com/orgmemory/api/OrgMemoryApiApplication.javacore/src/main/java/com/orgmemory/core/knowledge/graph/ClaimedGraphIndex.javacore/src/main/java/com/orgmemory/core/knowledge/graph/PersistedGraphProcessingProfile.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationCommand.javacore/src/main/java/com/orgmemory/core/knowledge/sourceledger/SourceIngestionCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/SecureKnowledgeRetrievalStore.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeUnavailableException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobQueue.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerConfiguration.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerService.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeResolver.javacore/src/main/java/com/orgmemory/core/knowledge/asset/KnowledgeChunkProjectionStore.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphView.javacore/src/test/java/com/orgmemory/core/knowledge/CanonicalHybridKnowledgeSearchTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRepository.javacore/src/test/java/com/orgmemory/core/knowledge/GraphRagKnowledgeRetrievalServiceTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobRepository.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRef.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingStoppedException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRegistry.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportService.javacore/src/main/java/com/orgmemory/core/knowledge/connector/ConnectorSourceRevisionCoordinator.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.java
**/*.java
📄 CodeRabbit inference engine (AGENTS.md)
Apply IDE inspection only to edited backend Java files.
Files:
apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.javacore/src/main/java/com/orgmemory/core/knowledge/graph/package-info.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfileRepository.javaapps/api/src/test/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementControllerTests.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfile.javaapps/worker/src/main/java/com/orgmemory/worker/OrgMemoryWorkerApplication.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportServiceTests.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.javacore/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinatorTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobStatus.javacore/src/main/java/com/orgmemory/core/knowledge/SecureRetrievalCandidate.javacore/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerServiceTests.javacore/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleServiceTests.javaapps/worker/src/test/java/com/orgmemory/worker/graph/GraphIndexingProcessorTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobView.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJob.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileResolver.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.javacore/src/main/java/com/orgmemory/core/knowledge/ResolvedKnowledgeEvidenceScope.javaapps/worker/src/main/java/com/orgmemory/worker/graph/GraphPublicationCommitter.javaapps/worker/src/test/java/com/orgmemory/worker/graph/GraphPublicationCommitterTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexChunk.javaapps/worker/src/main/java/com/orgmemory/worker/graph/GraphIndexingProcessor.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProperties.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphExplorerProperties.javaapps/api/src/main/java/com/orgmemory/api/OrgMemoryApiApplication.javacore/src/main/java/com/orgmemory/core/knowledge/graph/ClaimedGraphIndex.javacore/src/main/java/com/orgmemory/core/knowledge/graph/PersistedGraphProcessingProfile.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationCommand.javacore/src/main/java/com/orgmemory/core/knowledge/sourceledger/SourceIngestionCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/SecureKnowledgeRetrievalStore.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeUnavailableException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobQueue.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerConfiguration.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerService.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeResolver.javacore/src/main/java/com/orgmemory/core/knowledge/asset/KnowledgeChunkProjectionStore.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphView.javacore/src/test/java/com/orgmemory/core/knowledge/CanonicalHybridKnowledgeSearchTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRepository.javacore/src/test/java/com/orgmemory/core/knowledge/GraphRagKnowledgeRetrievalServiceTests.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobRepository.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRef.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingStoppedException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRegistry.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportService.javacore/src/main/java/com/orgmemory/core/knowledge/connector/ConnectorSourceRevisionCoordinator.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.java
apps/api/src/main/java/**/*.java
⚙️ CodeRabbit configuration file
apps/api/src/main/java/**/*.java: Enforce the browser-BFF and resource-server boundaries. Authentication
must resolve an active internal actor through the explicit issuer and
subject binding. Reject identity, tenant, roles, or permissions supplied
by request payloads, JWT email, or untrusted JWT role claims.
Files:
apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.javaapps/api/src/main/java/com/orgmemory/api/OrgMemoryApiApplication.java
core/src/main/java/com/orgmemory/core/{authorization,knowledge,permission}/**/*.java
⚙️ CodeRabbit configuration file
core/src/main/java/com/orgmemory/core/{authorization,knowledge,permission}/**/*.java: Treat PostgreSQL ACL evidence as canonical and OpenFGA as the relationship
authorization decision point. Authorization must fail closed. Filtering
must happen before ranking, LIMIT, graph traversal, answer generation,
export, and citation rendering. Flag metadata or timing leak paths.
Files:
core/src/main/java/com/orgmemory/core/knowledge/graph/package-info.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfileRepository.javacore/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfile.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobStatus.javacore/src/main/java/com/orgmemory/core/knowledge/SecureRetrievalCandidate.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobView.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJob.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileResolver.javacore/src/main/java/com/orgmemory/core/knowledge/ResolvedKnowledgeEvidenceScope.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexChunk.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProperties.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphExplorerProperties.javacore/src/main/java/com/orgmemory/core/knowledge/graph/ClaimedGraphIndex.javacore/src/main/java/com/orgmemory/core/knowledge/graph/PersistedGraphProcessingProfile.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationCommand.javacore/src/main/java/com/orgmemory/core/knowledge/sourceledger/SourceIngestionCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/SecureKnowledgeRetrievalStore.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeUnavailableException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobQueue.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerConfiguration.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerService.javacore/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeResolver.javacore/src/main/java/com/orgmemory/core/knowledge/asset/KnowledgeChunkProjectionStore.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinator.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphView.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRepository.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobRepository.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRef.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingStoppedException.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleService.javacore/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRegistry.javacore/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportService.javacore/src/main/java/com/orgmemory/core/knowledge/connector/ConnectorSourceRevisionCoordinator.java
🧠 Learnings (2)
📚 Learning: 2026-07-24T22:53:12.988Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 40
File: apps/api/src/main/java/com/orgmemory/api/knowledge/CitationContentController.java:0-0
Timestamp: 2026-07-24T22:53:12.988Z
Learning: For OrgMemory knowledge content handling in the API, treat `KnowledgeContentType` as the single closed policy (source of truth) for: canonical storage media type, browser-safe response media type, upload eligibility rules, and inline disposition behavior. Do not duplicate or bypass these decisions in controllers/services; route media-type and disposition logic through `KnowledgeContentType`. Specifically, Markdown should be stored with the canonical media type `text/markdown`, but served as `text/plain` when returning browser-safe citation preview content.
Applied to files:
apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.java
📚 Learning: 2026-07-26T05:46:47.443Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 61
File: apps/mcp/src/main/java/com/orgmemory/mcp/McpSecurityConfiguration.java:50-52
Timestamp: 2026-07-26T05:46:47.443Z
Learning: In OrgMemory, treat the `apps/mcp` and `apps/api` as independent protocol adapter modules. When adjusting OAuth/wire-level scopes, do not introduce a shared Java constant or create a code dependency from `apps/mcp` to `apps/api` solely to deduplicate scope values. Instead, keep OAuth/scope constants adapter-local (e.g., in the relevant adapter/security configuration classes) and ensure cross-adapter consistency via automated realm/OAuth/authorization tests, rather than via shared wiring-level constants or cross-module references.
Applied to files:
apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.javaapps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.javaapps/api/src/main/java/com/orgmemory/api/OrgMemoryApiApplication.java
🔇 Additional comments (51)
core/src/main/java/com/orgmemory/core/knowledge/graph/ClaimedGraphIndex.java (1)
1-3: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRepository.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileResolver.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProperties.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationCommand.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerConfiguration.java (1)
1-3: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerService.java (1)
1-7: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportService.java (1)
1-7: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphView.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/ResolvedKnowledgeEvidenceScope.java (1)
12-12: LGTM!Also applies to: 22-22, 45-55, 66-66
core/src/main/java/com/orgmemory/core/knowledge/graph/package-info.java (1)
1-9: 📐 Maintainability & Code QualityNo change needed. The SPRING MODULITH refactor increment documents the temporary OPEN boundary, independent architecture challenge, alternatives, graph module consumers, exposed types, closing exit criteria, and the ApplicationModules.verify() gate.
core/src/main/java/com/orgmemory/core/knowledge/graph/GraphExplorerProperties.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexChunk.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobQueue.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobRepository.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/SecureRetrievalCandidate.java (1)
5-5: LGTM!core/src/main/java/com/orgmemory/core/knowledge/connector/ConnectorSourceRevisionCoordinator.java (1)
4-4: LGTM!core/src/main/java/com/orgmemory/core/knowledge/sourceledger/SourceIngestionCoordinator.java (1)
4-4: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJob.java (1)
1-3: 🎯 Functional CorrectnessNo change needed.
SourceFailureMessageis declared aspublic, so the import fromcom.orgmemory.core.knowledge.graphis valid.core/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeResolver.java (1)
37-37: 🔒 Security & PrivacyNo change needed.
core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobStatus.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexJobView.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleService.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinator.java (1)
1-5: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphIndexingStoppedException.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRef.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/GraphProcessingProfileRegistry.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfile.java (1)
44-44: LGTM!core/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexingCoordinatorTests.java (1)
1-6: LGTM!core/src/main/java/com/orgmemory/core/knowledge/graph/PersistedGraphProcessingProfile.java (1)
1-1: 🗄️ Data Integrity & IntegrationNo change needed.
PersistedGraphProcessingProfile,GraphProcessingProfileRepository,GraphProcessingProfileRegistry, andGraphIndexJobreferences remain in the same package/entity scope, and the table/column model is unchanged.core/src/main/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationService.java (1)
1-9: LGTM!core/src/main/java/com/orgmemory/core/knowledge/KnowledgeEvidenceScopeUnavailableException.java (1)
3-8: LGTM!core/src/main/java/com/orgmemory/core/knowledge/EmbeddingProfileRepository.java (1)
7-7: LGTM!apps/worker/src/main/java/com/orgmemory/worker/graph/GraphIndexingProcessor.java (1)
6-9: LGTM!apps/worker/src/main/java/com/orgmemory/worker/graph/GraphPublicationCommitter.java (1)
3-5: LGTM!apps/worker/src/test/java/com/orgmemory/worker/graph/GraphIndexingProcessorTests.java (1)
22-27: LGTM!apps/worker/src/test/java/com/orgmemory/worker/graph/GraphPublicationCommitterTests.java (1)
12-17: LGTM!core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java (1)
56-89: LGTM!Also applies to: 107-112
core/src/test/java/com/orgmemory/core/knowledge/graph/GraphIndexLifecycleServiceTests.java (1)
1-1: LGTM!core/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExplorerServiceTests.java (1)
1-5: LGTM!core/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphExportServiceTests.java (1)
1-6: LGTM!core/src/main/java/com/orgmemory/core/knowledge/SecureKnowledgeRetrievalStore.java (1)
275-291: LGTM!apps/api/src/main/java/com/orgmemory/api/OrgMemoryApiApplication.java (1)
5-6: LGTM!apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeAssetLifecycleController.java (1)
4-5: LGTM!apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphExplorerController.java (1)
4-5: LGTM!apps/api/src/main/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementController.java (1)
5-7: LGTM!apps/api/src/test/java/com/orgmemory/api/knowledge/KnowledgeGraphManagementControllerTests.java (1)
10-12: LGTM!apps/worker/src/main/java/com/orgmemory/worker/OrgMemoryWorkerApplication.java (1)
6-7: LGTM!core/src/test/java/com/orgmemory/core/knowledge/CanonicalHybridKnowledgeSearchTests.java (1)
205-206: LGTM!core/src/test/java/com/orgmemory/core/knowledge/GraphRagKnowledgeRetrievalServiceTests.java (1)
893-895: LGTM!Also applies to: 914-916
core/src/test/java/com/orgmemory/core/knowledge/graph/KnowledgeGraphCurationServiceTests.java (1)
1-7: LGTM!
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knowledge.graphnested moduleVerification
:core:compileJavaand:core:compileTestJava:core:testpython scripts/check_docs.pypnpm release:checkclean testbefore main sync: 108 tasks, 5m13sclean testafterorigin/maine088e9c: 99 tasks, 6m18sclean testafterorigin/mainf99afb9 and conflict resolution: 108 tasks, 6m46sclean testafter review fix: 99 tasks, 6m26sScope
core.knowledgedirect Java files: 63 -> 40