リトライ回数を Proc の引数として受け取れるようにする - #1
Open
kyanny wants to merge 5 commits into
Open
Conversation
Check the arity of methods and decide to pass the retry count or not. If the given method does not accept any arguments, pass retry count raises ArgumentError so don't pass it.
Owner
|
たしかにリトライ回数の情報をもとに挙動かえたりなど利便性の高いパターンが多そうですね。性能的にも機能的にもよさげなので、確認の上取り込みます。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
リトライ回数を Proc (block) の引数で受け取れるにしてみました。
logger オプションでもリトライ回数は確認できますが、ブロックの中で明示的にログを出す場合などに、何回目のリトライなのかという情報を使いたいことはしばしばあります。
Proc の外にカウンタ用のインスタンス変数を用意することもできますが、 Proc のなかに閉じているほうがかっこいいと思うので、引数で渡すようにしました。
具体的にはこのような使い方をしたいと思っています。
https://gist.github.com/4267917