Skip to content

[AJDA-3062] Document Continue on Failure known issue in Flow Migration Guide#1045

Open
ondrajodas wants to merge 2 commits into
mainfrom
ondra/AJDA-3062
Open

[AJDA-3062] Document Continue on Failure known issue in Flow Migration Guide#1045
ondrajodas wants to merge 2 commits into
mainfrom
ondra/AJDA-3062

Conversation

@ondrajodas

Copy link
Copy Markdown
Contributor

Summary

Adds a new unlisted, searchable documentation page describing a known gap after migrating a Legacy Flow to a Conditional Flow, and links to it from the Migration Guide.

Known issue: Conditional Flows have no Continue on Failure toggle and therefore no job warning status. The Legacy Flow combination "continue on failure + send a warning notification" is not migrated automatically and must be rebuilt manually using conditions.

Changes

  • New page src/content/docs/flows/flow-migration-guide/continue-on-failure.md (slug flows/flow-migration-guide/continue-on-failure).
    • Deliberately not added to _data/navigation.yml → hidden from the left sidebar, but still built, reachable by URL, and indexed by Pagefind (full-text search).
    • Documents the known issue and a condition-based workaround, walked through on a GitHub + Google Sheets extractor example, with 6 screenshots.
  • Inbound link added from the Flow Migration Guide (the existing "Continue on Failure toggle" bullet).
  • 6 screenshots added (mirrored in src/content/docs/... and public/... per repo convention).

Verification

  • npm run build clean (260 pages).
  • node scripts/audit-phase2.mjs — no new link/image findings for the changed files.
  • Page confirmed unlisted (absent from navigation.yml/sidebar.mjs) yet Pagefind-indexed; all 6 images render.

Linear: AJDA-3062

Document the known gap after migrating a Legacy Flow to a Conditional Flow:
Conditional Flows have no Continue on Failure toggle and no warning job status.
Add an unlisted, searchable page with a condition-based workaround (walked through
on a GitHub + Google Sheets extractor example) and link to it from the Migration
Guide.
@linear-code

linear-code Bot commented Jul 24, 2026

Copy link
Copy Markdown

AJDA-3062

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
connection-docs Ready Ready Preview, Comment Jul 24, 2026 2:00pm

Request Review

@ondrajodas

Copy link
Copy Markdown
Contributor Author
# Release Notes
New Help documentation page: "Continue on Failure in Conditional Flows". It documents that migrated Conditional Flows have no Continue on Failure toggle and no warning job status, and shows how to reproduce the continue-on-failure + warning-notification behavior using conditions. The page is reachable by URL and via site search, and is linked from the Flow Migration Guide. It is intentionally not shown in the left sidebar.

# Plans for Customer Communication
No proactive announcement needed. The page is discoverable via search and via the inbound link from the Flow Migration Guide, which is where users hit this gap during/after migration. Support can share the direct URL when the question comes up.

# Impact Analysis
Documentation-only change to help.keboola.com. No product, API, or infrastructure impact. Adds one Markdown page, one inbound link edit, and 6 screenshots (mirrored in src/content/docs and public per repo convention). No changes to CSS, components, navigation.yml, or sidebar.mjs.

# Change Type
Documentation (new content + inbound link).

# Justification
Known gap after Legacy -> Conditional Flow migration: Conditional Flows lack the Continue on Failure toggle / warning status, so the "continue on failure + warning notification" behavior does not carry over and must be rebuilt with conditions. Users need a documented workaround. Linear: AJDA-3062.

# Deployment Plan
Standard docs deploy: merge to main triggers GitHub Actions (.github/workflows/main.yml) build + aws s3 sync to help.keboola.com. No config, secrets, or migrations required.

# Rollback Plan
Revert the merge commit (or delete the page + inbound link) and redeploy. Removing an unlisted page has no cross-page dependencies.

# Post-Release Support Plan
After deploy, verify the page renders at /flows/flow-migration-guide/continue-on-failure/, the 6 screenshots load, and it appears in site search. Follow-up: confirm the exact product UI labels with the product team and replace screenshots if the UI changes.

@keboola-pr-reviewer-bot keboola-pr-reviewer-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: needs_human (risk 2/5) · profile docs

Escalating: new page asserts unverifiable product-behaviour claims and adds 6 screenshots the reviewer can't visually check.

Concerns:

  • src/content/docs/flows/flow-migration-guide/continue-on-failure.md: New product-behaviour claim (no Continue-on-Failure toggle / no warning status) unverifiable by bot
  • src/content/docs/flows/flow-migration-guide/continue-on-failure.md: 6 new UI screenshots can't be visually verified against the step prose

Suggested reviewers: @keboola/docs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds documentation for a known migration gap when moving Legacy Flows to Conditional Flows, specifically covering how to replicate “Continue on Failure” behavior with conditions, and links this guidance from the existing Flow Migration Guide.

Changes:

  • Adds a new (unlisted-from-sidebar) documentation page explaining the known issue and a conditions-based workaround, with step-by-step screenshots.
  • Updates the Flow Migration Guide to link directly to the new “Continue on Failure in Conditional Flows” page.

Reviewed changes

Copilot reviewed 2 out of 14 changed files in this pull request and generated 1 comment.

File Description
src/content/docs/flows/flow-migration-guide/index.md Adds an inline link from the Migration Guide to the new known-issue/workaround page.
src/content/docs/flows/flow-migration-guide/continue-on-failure.md New page documenting the Continue-on-Failure migration gap and a conditions-based workaround with screenshots.
Comments suppressed due to low confidence (1)

src/content/docs/flows/flow-migration-guide/continue-on-failure.md:13

  • This sentence implies Conditional Flows cannot have a warning status at all, which conflicts with existing Conditional Flow docs that mention “warning” as a status you can branch on (src/content/docs/flows/index.md:78). If the intent is specifically that the Legacy Flow “Continue on Failure” mechanism no longer produces a warning state, consider clarifying that nuance here.
Conditional Flows have no **Continue on Failure** toggle, and therefore no job **warning** status. In Legacy Flows, the **warning** status appeared when a task with **Continue on Failure** enabled finished with an error. The combination of continuing on failure and sending a warning notification is not migrated automatically — you have to rebuild it manually using [conditions](/flows/#conditions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/content/docs/flows/flow-migration-guide/continue-on-failure.md Outdated
Avoid stating Conditional Flows have no warning status at all (they can branch
on a warning status via conditions); scope the wording to the Legacy Flow
continue-on-failure -> warning behavior that is not migrated automatically.
Addresses PR review feedback.

@MiroCillik MiroCillik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants