[AJDA-3062] Document Continue on Failure known issue in Flow Migration Guide#1045
[AJDA-3062] Document Continue on Failure known issue in Flow Migration Guide#1045ondrajodas wants to merge 2 commits into
Conversation
Document the known gap after migrating a Legacy Flow to a Conditional Flow: Conditional Flows have no Continue on Failure toggle and no warning job status. Add an unlisted, searchable page with a condition-based workaround (walked through on a GitHub + Google Sheets extractor example) and link to it from the Migration Guide.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
Escalating: new page asserts unverifiable product-behaviour claims and adds 6 screenshots the reviewer can't visually check.
Concerns:
src/content/docs/flows/flow-migration-guide/continue-on-failure.md: New product-behaviour claim (no Continue-on-Failure toggle / no warning status) unverifiable by botsrc/content/docs/flows/flow-migration-guide/continue-on-failure.md: 6 new UI screenshots can't be visually verified against the step prose
Suggested reviewers: @keboola/docs
There was a problem hiding this comment.
Pull request overview
Adds documentation for a known migration gap when moving Legacy Flows to Conditional Flows, specifically covering how to replicate “Continue on Failure” behavior with conditions, and links this guidance from the existing Flow Migration Guide.
Changes:
- Adds a new (unlisted-from-sidebar) documentation page explaining the known issue and a conditions-based workaround, with step-by-step screenshots.
- Updates the Flow Migration Guide to link directly to the new “Continue on Failure in Conditional Flows” page.
Reviewed changes
Copilot reviewed 2 out of 14 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/content/docs/flows/flow-migration-guide/index.md | Adds an inline link from the Migration Guide to the new known-issue/workaround page. |
| src/content/docs/flows/flow-migration-guide/continue-on-failure.md | New page documenting the Continue-on-Failure migration gap and a conditions-based workaround with screenshots. |
Comments suppressed due to low confidence (1)
src/content/docs/flows/flow-migration-guide/continue-on-failure.md:13
- This sentence implies Conditional Flows cannot have a warning status at all, which conflicts with existing Conditional Flow docs that mention “warning” as a status you can branch on (src/content/docs/flows/index.md:78). If the intent is specifically that the Legacy Flow “Continue on Failure” mechanism no longer produces a warning state, consider clarifying that nuance here.
Conditional Flows have no **Continue on Failure** toggle, and therefore no job **warning** status. In Legacy Flows, the **warning** status appeared when a task with **Continue on Failure** enabled finished with an error. The combination of continuing on failure and sending a warning notification is not migrated automatically — you have to rebuild it manually using [conditions](/flows/#conditions).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Avoid stating Conditional Flows have no warning status at all (they can branch on a warning status via conditions); scope the wording to the Legacy Flow continue-on-failure -> warning behavior that is not migrated automatically. Addresses PR review feedback.
Summary
Adds a new unlisted, searchable documentation page describing a known gap after migrating a Legacy Flow to a Conditional Flow, and links to it from the Migration Guide.
Known issue: Conditional Flows have no Continue on Failure toggle and therefore no job warning status. The Legacy Flow combination "continue on failure + send a warning notification" is not migrated automatically and must be rebuilt manually using conditions.
Changes
src/content/docs/flows/flow-migration-guide/continue-on-failure.md(slugflows/flow-migration-guide/continue-on-failure)._data/navigation.yml→ hidden from the left sidebar, but still built, reachable by URL, and indexed by Pagefind (full-text search).src/content/docs/...andpublic/...per repo convention).Verification
npm run buildclean (260 pages).node scripts/audit-phase2.mjs— no new link/image findings for the changed files.navigation.yml/sidebar.mjs) yet Pagefind-indexed; all 6 images render.Linear: AJDA-3062