Skip to content

Omit nomodule attribute value as it's boolean - #966

Open
shinnn wants to merge 1 commit into
kangax:gh-pagesfrom
shinnn:nomodule
Open

Omit nomodule attribute value as it's boolean#966
shinnn wants to merge 1 commit into
kangax:gh-pagesfrom
shinnn:nomodule

Conversation

@shinnn

@shinnn shinnn commented Sep 25, 2018

Copy link
Copy Markdown
Contributor

Before

const {minify} = require('html-minifier');

minify('<script nomodule="nomodule"></script>', {collapseBooleanAttributes: true});
//=> '<script nomodule="nomodule"></script>'

After

const {minify} = require('html-minifier');

minify('<script nomodule="nomodule"></script>', {collapseBooleanAttributes: true});
//=> '<script nomodule></script>'

ref. specification of nomodule attribute: https://html.spec.whatwg.org/multipage/scripting.html#attr-script-nomodule

@shinnn

shinnn commented Dec 17, 2018

Copy link
Copy Markdown
Contributor Author

Could anyone review this?

@alexlamsl

alexlamsl commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

Please add a test case (around here) to make sure your change is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants