Skip to content

refactor: resolve idiomatic audit findings - #349

Merged
jongio merged 1 commit into
mainfrom
fix/audit-idioms
Aug 8, 2026
Merged

refactor: resolve idiomatic audit findings#349
jongio merged 1 commit into
mainfrom
fix/audit-idioms

Conversation

@jongio

@jongio jongio commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace mutable sync.Once test resets with explicit MCP security-policy injection
  • parse extension.yaml with yaml.v3 in Mage and cover valid and invalid manifests
  • keep shell and PowerShell fallback version extraction consistent for quoted YAML values

Validation

  • go test ./...
  • go build ./...
  • go test -tags mage -run TestParseExtensionVersion .
  • PowerShell and Bash syntax validation
  • Mage preflight passed steps 1 through 12; step 13 is temporarily blocked by minimum release age policy for dependencies already on main

Closes #102

Inject MCP security policies explicitly in request tests and parse extension versions consistently without resetting initialized singleton state.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b78c0ea1-e8e1-45f9-92f2-2d8a28f8679f
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Website Preview

Your PR preview was available here.

Preview has been cleaned up as the PR was closed.

github-actions Bot added a commit that referenced this pull request Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Test This PR

A preview build (0.5.0-pr349) is ready for testing!

One-Line Install (Recommended)

PowerShell (Windows):

iex "& { $(irm https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/install-pr.ps1) } -PrNumber 349 -Version 0.5.0-pr349"

Bash (macOS/Linux):

curl -fsSL https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/install-pr.sh | bash -s 349 0.5.0-pr349

Uninstall

PowerShell (Windows):

iex "& { $(irm https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/uninstall-pr.ps1) } -PrNumber 349"

Bash (macOS/Linux):

curl -fsSL https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/uninstall-pr.sh | bash -s 349

Build Info:

@jongio
jongio merged commit 29da851 into main Aug 8, 2026
13 checks passed
@jongio
jongio deleted the fix/audit-idioms branch August 8, 2026 14:22
github-actions Bot added a commit that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

idiomatic code audit: findings for azd-rest

1 participant