Preserve Google per-event colors through calendar sync - #133
Merged
Conversation
Google's API returns colorId on individually recolored events, but fetchGoogleEvents kept only three fields from each item and discarded it, so every event rendered in its calendar's color. Resolve colorId to a hex at sync time via the /colors endpoint (cached 24h) and store it in the existing raw_data column, then surface it as event_color from getCachedEvents. Clients prefer event_color and fall back to source_color, so events left on a calendar's default color are unchanged. No schema migration needed.
…ture listEventColors cached its result on both paths, so one transient failure (network blip, token-refresh race, a 5xx) pinned an empty palette for the full 24h TTL. Because the hex is resolved into raw_data at sync time, every event synced in that window stayed uncolored until a later sync after the cache expired. Cache only successes; a failure now retries on the next sync at the cost of one request, and keeps logging the error. Also documents per-event colors in features.md and corrects two comments that still claimed the day-view chip always carries the calendar color. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
Thanks @Leesam nice contribution! Claude developed, Claude approved. One minor tweak was made in the even a failed palette fetch gets cached. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google's API returns colorId on individually recolored events, but fetchGoogleEvents kept only three fields from each item and discarded it, so every event rendered in its calendar's color.
Resolve colorId to a hex at sync time via the /colors endpoint (cached 24h) and store it in the existing raw_data column, then surface it as event_color from getCachedEvents. Clients prefer event_color and fall back to source_color, so events left on a calendar's default color are unchanged. No schema migration needed.
Disclosure: written with AI assistance (Claude), tested by me on my own OMV/Docker install.