Remove dead widget plugin template lookup - #3447
Open
Salvialf wants to merge 1 commit into
Open
Conversation
Salvialf
added
the
changelog-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dedicated template lookup for the (deprecated, obsolete on the market)
widgetplugin incmd::getWidgetTemplateCode()was dead code.Its result was always immediately discarded by the following unconditional
getTemplate(..., $this->getEqType())call added in a 2023 commit, which overwrites$templateregardless of what thewidgetblock found. Even without that, the check was already redundant: the genericplugin::listPlugin(true)fallback loop right after tests every active plugin's own template folder using the sameactivecondition, so an activewidgetplugin would already be picked up there.