Speed up plugin::isInstalled and use it instead of byId for existence checks - #3446
Open
Salvialf wants to merge 3 commits into
Open
Speed up plugin::isInstalled and use it instead of byId for existence checks#3446Salvialf wants to merge 3 commits into
Salvialf wants to merge 3 commits into
Conversation
Salvialf
added
the
changelog-dev
zoic21
approved these changes
Jul 29, 2026
zoic21
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin::isInstalled()no longer goes throughplugin::byId()(full JSON decode, object hydration,method_existschecks, category resolution) just to answer a yes/no question. It now resolves the plugin path and validates the JSON directly, without building apluginobject.plugin::byId()arguments and return type are now typed (string $_id, bool $_full = false): plugin), and both methods share a new privateresolvePath()helper instead of duplicating the path resolution logic.plugin::byId()calls incorethat were only used to check plugin existence, never using the returned object, withplugin::isInstalled():cache::clean(),jeedom::getApiKey(), and thejeeasydetection in the first-use modal.