change ignoreFile to receive a complete filepath

[hpacheco]

Hi,

When reading the documentation, I was under the impression that the ignoreFile function should receive a complete FilePath from the providerDirectory, but it was actually only receiving the file name -- due to the behavior of the getRecursiveContents function.
I have made a simple extension to getRecursiveContents to mitigate this.
I am not sure if this was intentional or not; if that was the case, then I think that it would deserve a remark in the docs.

Cheers,
hugo

[jaspervdj]

Hi @hpacheco -- I understand why you would want this to receive the whole path. However, I can't change this now as this would break the behavior of some websites. Maybe we can add a second option, ignorePath, document the behavior and ignore the file if either of the two functions is true?

[hpacheco]

Hi Jasper, I understand, but just need to change it for my solution. Any solution that offers the option sounds great. Thanks, hugo

…

On Sat, Nov 24, 2018 at 11:02 PM Jasper Van der Jeugt < ***@***.***> wrote: Hi @hpacheco <https://github.com/hpacheco> -- I understand why you would want this to receive the whole path. However, I can't change this now as this would break the behavior of some websites. Maybe we can add a second option, ignorePath, document the behavior and ignore the file if either of the two functions is true? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#667 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIq_px3yL2dRnfJZTJFd_8-pKRgNpCBks5uydAUgaJpZM4XSZuu> .

-- www.di.uminho.pt/~hpacheco

[jaspervdj]

I'm happy to accept a patch that does this but preserving backwards compatibility is essential. Unfortunately I don't really have time to put this together myself.