Fix unable to load *.so plugins#315
Open
wie-niet wants to merge 1 commit into
Open
Conversation
python3-mpv loads libmpv with RTLD_LOCAL, preventing C plugins such as mpv-mpris from resolving libmpv symbols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix
Fixes an issue where mpv *.so plugins fail to load, python3-mpv loads libmpv with RTLD_LOCAL, preventing C plugins such as mpv-mpris from resolving libmpv symbols.
when trying to load mpv with mpris.so using mpv.MPV(config=True, log_handler=print, loglevel='debug'):
error mpris2 C plugin error: '/etc/mpv/scripts/mpris.so: undefined symbol: mpv_get_property_string'Changes
Changed one line 70 in mpv.py to load share object file with ctypes.RTLD_GLOBAL, so symbol mpv_get_property_string can be resolved.
Testing
Tested with:
The issue no longer occurs.