fix: set widget.hidden in toggleWidget_2 to prevent textarea overlap in modern frontend

[DDavisWA]

Problem

In ComfyUI frontend >= v1.43.18, multiline STRING widgets (CLIP_POSITIVE / CLIP_NEGATIVE in the Efficient Loader) are rendered as DOM elements whose Y-position is calculated by accumulating the heights of all preceding widgets. The frontend uses widget.hidden to skip excluded widgets in this accumulation.

toggleWidget_2 (used for the Efficient Loader) was hiding lora_model_strength and lora_clip_strength by setting widget.type and widget.computeSize only — without setting widget.hidden. Those widgets still contributed to the Y-offset accumulation, pushing the CLIP text boxes down into the fields below them (token_normalization, weight_interpretation, etc.).

Fix

One line added to toggleWidget_2, mirroring the pattern already present in toggleWidget:

widget.hidden = !show;

Testing

Open an Efficient Loader node with lora_name = None. CLIP_POSITIVE and CLIP_NEGATIVE text boxes sit in their correct positions and no longer overlap the fields below them.

Related

Part of the fix for #344 (efficiency-nodes UI trouble). This PR covers toggleWidget_2 (Efficient Loader text boxes); #384 covers the same class of bug in toggleWidget (XY Input / quantity-adjust nodes). The two together resolve the widget-overlap issues reported in #344.

[hwyao]

Comment on PR #384 #385

I tested #384 and #385 together on ComfyUI frontend v1.43.18 and found one remaining Node Details case.

Reproduction workflow and evidence

widgethider-check.json
This is widgethider-check.json as a UI reproduction workflow. It contains:

• Efficient Loader
• XY Input: VAE
• XY Input: Steps
• XY Input: Sampler/Scheduler
• LoRA Stacker

The workflow is intended for UI verification; it does not need to be queued.

Before (Nothing):

After 1 (after applying #384 #385):

Remaining issue

#384 and #385 correctly update widget.hidden, so canvas rendering and DOM-widget positioning are fixed.

However, when the right-side Node Details / Parameters panel is already open, changing a mode or count that reveals additional Efficiency Nodes widgets can leave the newly visible parameter rows overflowing or misaligned.

After 2 (after applying #384 #385, triggering error):

Root cause

The frontend has two visibility consumers:

• Canvas layout observes widget.hidden.
• Node Details filters widgets through widget.options?.hidden.

In this PR, the relevant code is the toggleWidget_2 helper in js/widgethider.js, immediately after the widget.hidden = !show; line added by this PR (around line 53 in commit 7f9f6b5).

ComfyUI frontend's own PreviewAny extension synchronizes both fields:
https://github.com/Comfy-Org/ComfyUI_frontend/blob/v1.43.18/src/extensions/core/previewAny.ts

Proposed follow-up

Please add this immediately after widget.hidden = !show; for #384 and #385:

if (widget.options) widget.options.hidden = !show;

I will open a focused stacked PR at
https://github.com/DDavisWA/efficiency-nodes-comfyui/tree/fix-xyinput-stray-widget
https://github.com/DDavisWA/efficiency-nodes-comfyui/tree/fix/efficient-loader-textarea-overlap
against for these to pr.

Last (after applying #384 #385 and my patches):

Basic Stability Test

default-step-cfg-XY.json
I ran a XY plot for CFG-steps, and it is not crashed. There is no full coverage test and this is therefore only a small experiment.