Skip to content

more guidance for clankers in lint errors - #31

Merged
mmkal merged 4 commits into
mainfrom
mmkal/26/08/13/moreguidanceforclankersinlinterrors
Aug 14, 2026
Merged

more guidance for clankers in lint errors#31
mmkal merged 4 commits into
mainfrom
mmkal/26/08/13/moreguidanceforclankersinlinterrors

Conversation

@mmkal

@mmkal mmkal commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Lint failures now give concrete spinnerWaiter guidance instead of only naming the violated rule.

  • prefer-locator-waits explains why locator-native waits work better with spinnerWaiter.
  • require-timeout-comment lists fixes for existing, missing, slow, custom, and disabled loading UI.
  • prefer-positive-waits explains how to replace or justify detached waits.
  • Multiline messages have no leading blank line, shared indentation, or trailing whitespace.

The lint text keeps the existing docs links and key remediation phrases so downstream expectations remain stable.

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm build
  • pnpm exec publint
  • pnpm test — 144 passed, 3 skipped

Todo-app video baseline

video-rendered.webm

Codex session: PR #31 dedent and CI fix — 01a00070-794d-7b52-ae0a-2ff6f97ba972


Note

Low Risk
Changes are limited to lint message strings and a formatting test; detection, fixes, and required-pattern matching are untouched.

Overview
Lint rule messages are rewritten so failures give actionable spinnerWaiter guidance instead of short rule reminders.

prefer-locator-waits one-line messages now mention benefiting from spinnerWaiter’s loading UI detection. require-timeout-comment and prefer-positive-waits use dedent for multi-step remediation (remove timeouts, add loading UI, spinnerWaiter.settings.run options, comment patterns, and docs links). Rule logic and autofix behavior are unchanged.

A new spec asserts multiline messages are trimmed and have no indented lines, so oxlint output stays readable.

Reviewed by Cursor Bugbot for commit e9d224b. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/lint/plugin.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 442d3fd. Configure here.

Comment thread src/lint/plugin.ts Outdated
@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/middlewright@31

commit: e9d224b

@mmkal
mmkal merged commit 8b0f606 into main Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant