Proposed improvement to Invalid mode dialog for Canon Cameras - #314
Open
paulskirk53 wants to merge 4 commits into
Open
Proposed improvement to Invalid mode dialog for Canon Cameras#314paulskirk53 wants to merge 4 commits into
paulskirk53 wants to merge 4 commits into
Conversation
The 'Invalid Mode' dialog has been enhanced to guide users to check the Movie/Still switch on cameras like the EOS 6D, preventing confusion when the camera is in Movie mode, which prevents 'Bulb' connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 'Invalid Mode' dialog has been enhanced to guide users to check the Movie/Still switch on cameras like the EOS 6D, preventing potential confusion when the camera is in Movie mode, which prevents 'Bulb' connection.
🚀 Purpose
Problem
Canon 6D users (and potentially other models with a Movie/Still switch) will encounter the "Invalid Mode" error when the camera's physical 'Movie/Still' switch is set to 'Movie', even if the Mode Dial is set to 'B'.
In Movie mode, the Canon EDSDK fails to report valid Bulb data, (investigated in NINA's EDCamera.cs code), causing NINA to reject the connection. The existing error message ("Camera is not in Manual or Bulb mode") does not mention the need for the Movie/ Still switch to be set to ‘still’ for Bulb connection to be successful.
Solution
Updated the error message
LblEDCameraNotInManualModeinLocale.resx(the English language messages only) to explicitly instruct users to check the Movie/Still switch.Proposed new message below:
Camera is not set to manual or bulb mode! Please set it to manual or bulb mode
and If your camera has a Movie/Still switch, ensure it is set to 'Still' before connecting.
🧪 How Was It Tested?
Testing
Multiple manual tests were made using the above test scenario. These involved cycling camera power, disconnecting/ reconnecting the camera in NINA and plugging/ unplugging the USB cable. Only one Canon 6D camera was used.
🤖 AI / Tooling Disclosure
None
✅ PR Checklist
RELEASE_NOTES.mdupdated (if applicable)🔗 Related Issues
📸 Screenshots
before
after

📝 Additional Notes
If the proposed change is accepted, the non English sections of the Locale.resx file will need to be updated
Thank you for considering this.