fix #557: improve the clarity of logging in TripPlanner - #568
Open
alexmgns wants to merge 4 commits into
Open
Conversation
…de router failing to find a direct trip from warn to info.
…rip-planner-clearer-log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the clarity of the logging when an origin or destination has a problem in the trip planner. Previously would only give the from and to ids of the problematic trip, but the routing can start at a different origin, say after a transit leg. These coordinates are now also reported.
Also downgraded message when the router isn't able to find a direct trip from warn to info. This event happens quite frequently, say when the router tries to route a direct walk trip from origin to destination before taking a transit trip to get closer.
Closes #557