[IMP] l10n_uy_ux: strip internal reference prefix from NomItem - #440
Closed
jue-adhoc wants to merge 1 commit into
Closed
[IMP] l10n_uy_ux: strip internal reference prefix from NomItem#440jue-adhoc wants to merge 1 commit into
jue-adhoc wants to merge 1 commit into
Conversation
Contributor
|
|
The internal reference is now reported in its own <CodItem> node (TpoCod INT1) by l10n_uy_edi, so it should no longer be embedded in the item name. Since we build NomItem from the line description (line.name), which by default starts with the "[default_code]" prefix, we strip that prefix when it matches the product internal reference. Any other user-written text is preserved as is.
jue-adhoc
force-pushed
the
19.0-h-125178-jue
branch
from
August 24, 2026 12:29
6cec820 to
fc77390
Compare
zaoral
approved these changes
Aug 24, 2026
zaoral
left a comment
zaoral
left a comment
Contributor
There was a problem hiding this comment.
@roboadhoc override=ci/runbot-oba
We force this merge because is needed to be able to update odoo image. After both are in the image then the ci/runbot problem will be resolved
@roboadhoc nobump r+
roboadhoc
pushed a commit
that referenced
this pull request
Aug 24, 2026
The internal reference is now reported in its own <CodItem> node (TpoCod INT1) by l10n_uy_edi, so it should no longer be embedded in the item name. Since we build NomItem from the line description (line.name), which by default starts with the "[default_code]" prefix, we strip that prefix when it matches the product internal reference. Any other user-written text is preserved as is. closes #440 Signed-off-by: Katherine Zaoral - kz (#l10n) <kz@adhoc.com.ar>
Contributor
|
@jue-adhoc @zaoral staging failed: ci/runbot-oba on 82f4b867b0585a01949e2e415f07e77d68aac092 (view more at https://runbot.dev-adhoc.com//runbot/batch/104381/build/105619) |
Contributor
|
@roboadhoc retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since https://github.com/odoo/enterprise/pull/128600,
l10n_uy_edireports the product internal reference in its own<CodItem>node (TpoCodINT1) of the CFE XML, and no longer embeds it inNomItem.l10n_uy_uxoverrides_l10n_uy_edi_get_line_nom_and_desc()to buildNomItemfrom the line description (line.name), which by default starts with the[default_code]prefix. This change strips that prefix when it matches the product internal reference, so the code is not duplicated in the item name: it travels in<CodItem>. Only the standard prefix is stripped — any other user-written text (including a reference mentioned elsewhere in the description) is preserved as is.l10n_uy_edichange above is available in the OBA image; otherwise the internal reference would disappear fromNomItemwithout a<CodItem>replacing it.Test plan: new test
test_130_nom_item_strips_internal_reference(prefix stripped, non-prefix mentions preserved); existingtest_110/test_120unaffected.Internal reference: https://www.adhoc.inc/odoo/helpdesk/125178