once over after artisan ide-helper:models -RW - #1056
Merged
Merged
Conversation
Contributor
Author
However |
…d missing properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-RW is fairly noisy - it resets existing phpdoc and starts over. I wanted to get ahead of that during a release by doing it now.
It added a fair bit of churn in this occasion. I noted the reasons as I reviewed:
\Illuminate\Database\Eloquent\Buildertype might becomeBuilderif we imported it.Besides refreshing property, scope*, and automated where* methods, I came across the following:
Finally:
I ran into an edge case when it generates type hints for scope* methods in a child class, ie, only relevant to Aggregator classes which all tend to extend a Model. If the Model has a scope method, and it typehints
Builder(not FQDN), then the child class won't use the FQDN in the type-hint.. the type hint is forBuilderalthough there's no import for it. Opened issue: barryvdh/laravel-ide-helper#1795