feat: migrate to gobenchdata for continuous benchmarking with PR comments only#20
Conversation
- Replace custom benchmark workflow with gobenchdata action - Add gobenchdata-checks.yml configuration for performance monitoring - Use peter-evans actions for PR comment management - Update README.md to document new continuous benchmarking system - Configure thresholds for ns/op (20%), B/op (25%), and allocs/op (15%) Co-authored-by: icedream <807772+icedream@users.noreply.github.com>
- Use Mem.BytesPerOp and Mem.AllocsPerOp to match actual benchmark JSON structure - Tested with gobenchdata CLI to verify checks work correctly Co-authored-by: icedream <807772+icedream@users.noreply.github.com>
- Add benchmark-publish.yml workflow to create baseline data on main branch pushes - Configure workflow to publish to gh-pages with conventional commit messages - Add continue-on-error to benchmark checks to handle missing baseline gracefully - Use PRUNE_COUNT to limit stored benchmark history to 30 runs Co-authored-by: icedream <807772+icedream@users.noreply.github.com>
|
@copilot Can you make it so using actions peter-evans/find-comment@v3 and peter-evans/create-or-update-comment@v4 we do not publish benchmark comparisons to GitHub Pages but instead to a comment on a PR again? |
Co-authored-by: icedream <807772+icedream@users.noreply.github.com>
Done! I've updated the benchmark workflow to remove GitHub Pages publishing from the PR workflow. Now the The baseline benchmark data will still be published to the gh-pages branch when changes are merged to main (via |
This PR migrates the repository from a custom benchmark comparison workflow to use the gobenchdata action for continuous benchmarking, configured to publish results only as PR comments rather than to GitHub Pages.
Changes Made
🔄 Workflow Migration
benchmark.ymlworkflow with a gobenchdata-based implementationbenchmark-publish.ymlto establish baseline benchmark data on main branch pushes🛠️ Comment Management
peter-evans/find-comment@v3for finding existing benchmark commentspeter-evans/create-or-update-comment@v4for creating/updating PR comments⚙️ Configuration
gobenchdata-checks.ymlwith performance regression thresholds:📚 Documentation
💯 Conventional Commits
Benefits
Testing
The new workflow establishes baseline data when changes are merged to main, and subsequent PRs show performance comparisons in PR comments only without publishing to GitHub Pages during the review process.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.