Conversation
Hyperlink.ClickEvent is registered as ButtonBase.ClickEvent.AddOwner(...), i.e. it is the very same routed event as the button's own Click. The inner Hyperlink is a logical child, so the Click raised by DoClick() bubbled back up to the HyperlinkButton and fired the user's Click handler a second time on every single click (#407). Mark the inner Hyperlink's Click as handled so it no longer bubbles: DoClick() still performs navigation while Click is raised exactly once by base.OnClick(). DoClick() is now only invoked when NavigateUri is set. Remove RaiseHyperlinkClicks: it was a workaround that defaulted to the buggy double-raise behaviour and, when turned off, also disabled navigation because both were coupled to the same DoClick() call. BREAKING CHANGE: the RaiseHyperlinkClicks property has been removed. Remove any references to it; the double-Click it worked around no longer occurs. Fixes #407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyperlink.ClickEvent is registered as ButtonBase.ClickEvent.AddOwner(...), i.e. it is the very same routed event as the button's own Click. The inner Hyperlink is a logical child, so the Click raised by DoClick() bubbled back up to the HyperlinkButton and fired the user's Click handler a second time on every single click (#407).
Mark the inner Hyperlink's Click as handled so it no longer bubbles: DoClick() still performs navigation while Click is raised exactly once by base.OnClick(). DoClick() is now only invoked when NavigateUri is set.
Remove RaiseHyperlinkClicks: it was a workaround that defaulted to the buggy double-raise behaviour and, when turned off, also disabled navigation because both were coupled to the same DoClick() call.
Fixes #407