Conversation
Expander and SettingsExpander always played their expand/collapse animation, ignoring the Windows 11 Accessibility -> Visual effects -> Animation effects setting, unlike NavigationView and other controls. ExpanderAnimationsHelper.RunExpanderAnimation now checks Helper.IsAnimationsEnabled (SystemParameters.ClientAreaAnimation) and snaps the content to its target state instead of animating when animations are disabled system-wide. Closes #430
Removed an accidental leading `s` before an `if` statement in `RunExpanderAnimation`, restoring valid C# syntax and ensuring the animation-enabled check compiles correctly.
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ExpanderAnimationsHelper so Expander/SettingsExpander respects the Windows “Animation effects” accessibility setting by skipping expand/collapse animations when system-wide animations are disabled.
Changes:
- Added a system animation-enabled gate (
Helper.IsAnimationsEnabled) before running expander animations. - When animations are disabled, the expander content is snapped directly to its expanded/collapsed state instead of animating.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Waiting for #430 OP to confirm the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expander and SettingsExpander always played their expand/collapse animation, ignoring the Windows 11 Accessibility -> Visual effects -> Animation effects setting, unlike NavigationView and other controls.
ExpanderAnimationsHelper.RunExpanderAnimation now checks Helper.IsAnimationsEnabled (SystemParameters.ClientAreaAnimation) and snaps the content to its target state instead of animating when animations are disabled system-wide.
Closes #430