Fix the Pojora potency rune not being marked as junk - #13
Open
S-Del wants to merge 1 commit into
Open
Conversation
The item ID of the Pojora potency rune is 45808, but it was specified as 45508, which is the ID of hake. Because of this, ticking the Pojora potency rune in the settings menu did not mark it as junk. This change alone does not solve the problem for existing users, so each user has to apply the fix manually. Every occurrence of the ID "45508" in SavedVariables/Dustman.lua has to be replaced with "45808". The game has to be closed while editing the file, otherwise the change is overwritten when logging out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is wrong
The item ID of the Pojora potency rune is 45808, but it is specified as 45508 in the default settings in
Dustman.lua. 45508 is the ID of hake, an unrelated item.DustmanData.luauses the correct ID for the label, so the checkbox for Pojora is shown in the settings menu and can be ticked. However,GetPotencyRule()compares the ID of the item in the inventory against the ID stored in the settings, and those never match. As a result, Pojora runes were not marked as junk even when the option was enabled.The change
The default ID of entry [22] is corrected from "45508" to "45808". With this, all 31 potency rune IDs in
Dustman.luamatch the ones inDustmanData.lua.Note for existing users
ZO_SavedVarsonly fills in keys that are missing from the saved data, so this change does not reach installations that already have saved settings. The wrong ID stays inSavedVariables/Dustman.luaand has to be corrected by hand:Every occurrence has to be replaced.
Dustman_SavedVariablesholds one block per character andDustman_GlobalSavedVariablesholds one more, so the number of occurrences is the number of characters on the account plus one.The game has to be closed while editing the file. If it is edited while the game is running, the change is overwritten with the in-memory settings when logging out.
Deleting
SavedVariables/Dustman.luawith the game closed works as well, but it resets all Dustman settings.