Fix some potency runes missing from the settings menu - #12
Open
S-Del wants to merge 1 commit into
Open
Conversation
The loop that builds the menu only iterated up to 28 entries, so the last three runes, Repora, Rera and Tade, never appeared in the menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the potency rune menu was built, the loop only ran up to 28 entries, so the list stopped at the "Rekura" rune.
By deriving the loop's upper bound from the defaults table itself, the number of entries displayed now matches the definition, and it will follow along automatically if new runes are added in the future.
