Change to display in English when no locale file exists - #10
Open
S-Del wants to merge 1 commit into
Open
Conversation
Before this change, the manifest loaded only Language/$(language).lua. Because of this, on clients using a language with no locale file (jp, es, it, br, zh, and so on), none of the DUSTMAN_* string IDs were obtained at all. Therefore no error occurred and the addon still loaded, but most of the labels in the settings panel were not displayed. This commit loads Language/en.lua first as the default, so that all IDs are set. After that, the file for each language overrides what it defines there. As a result, labels that are defined in a language's locale file are displayed in that language, and labels that are not defined there are displayed in English.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for providing such a useful add-on.
For the reason described below I have modified part of the code, and I would be grateful if you would consider merging it.
Motivation for this request
When the game client's language does not exist in the
Language/directory, many of the labels in this add-on's settings panel were blank.Benefit of merging this request
Even when the language does not exist in
Language/, English labels will be displayed.This is unrelated to this PR, but the APIVersion in the manifest (
Dustman.txt) has been left at 101039, which is out of date.If you do decide to accept this pull request, I would be grateful if you could update that as well.