Finish the checkmate/rlang migration leftovers from #548 - #600
Merged
Conversation
Three items were prepared while #548 was open but did not land before it merged. Five rlang::abort() calls carrying `# nocov` are collapsed onto one line, so the marker is a trailing comment rather than a `# nocov start` / `# nocov end` bracket. interpolate.conc.R drops from three bracketed regions to none. The last two base stop() calls left by #548's sweep -- in prepare_data.R and time.above.R -- become classed rlang::abort() calls, and time.above.R's multi-argument message becomes a sprintf template so the text can be grepped for. Redundant `.var.name` arguments are dropped where they repeat what checkmate already reports. The fifteen that remain are kept deliberately: the thirteen in PKNCA.options.R would degrade to "Assertion on 'x'", prepare_data.R's would report `unlist(cols)`, and superposition.R's disambiguates a checkmate::assert() with two candidate checks. Not covered here: R/bioequivalence.R and the conditions added by #588 to R/superposition.R both use base stop()/warning(). They arrived after #548's merge base and are a separate migration. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three items were prepared while #548 was open but did not land before it merged.
Five rlang::abort() calls carrying
# nocovare collapsed onto one line, so the marker is a trailing comment rather than a# nocov start/# nocov endbracket. interpolate.conc.R drops from three bracketed regions to none.The last two base stop() calls left by #548's sweep -- in prepare_data.R and time.above.R -- become classed rlang::abort() calls, and time.above.R's multi-argument message becomes a sprintf template so the text can be grepped for.
Redundant
.var.namearguments are dropped where they repeat what checkmate already reports. The fifteen that remain are kept deliberately: the thirteen in PKNCA.options.R would degrade to "Assertion on 'x'", prepare_data.R's would reportunlist(cols), and superposition.R's disambiguates a checkmate::assert() with two candidate checks.Not covered here: R/bioequivalence.R and the conditions added by #588 to R/superposition.R both use base stop()/warning(). They arrived after #548's merge base and are a separate migration.