Add Hotspring sensor platform - #179697
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a sensor platform to expose Hot Spring spa temperatures, salt-system data, and firmware versions.
Changes:
- Registers seven coordinator-backed sensor entities.
- Adds entity translations.
- Adds fixtures, behavioral tests, and snapshots.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/hotspring/__init__.py |
Registers the sensor platform. |
homeassistant/components/hotspring/sensor.py |
Implements sensor entities and descriptions. |
homeassistant/components/hotspring/strings.json |
Adds sensor names. |
tests/components/hotspring/conftest.py |
Adds water-care fixture data. |
tests/components/hotspring/test_sensor.py |
Tests sensor creation and filtering. |
tests/components/hotspring/snapshots/test_sensor.ambr |
Captures sensor states and registry metadata. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "sensor.connectedspa_ddeeff_freshwater_salt_system_version", | ||
| ], | ||
| ) | ||
| async def test_disabled_by_default_sensors( |
There was a problem hiding this comment.
We don't have to test the disabled internal feature. What you can do in the snapshot is the enable all entities and they run along in the snapshot test. :)
| assert entry.disabled_by is er.RegistryEntryDisabler.INTEGRATION | ||
|
|
||
|
|
||
| async def test_no_salt_cartridge( |
There was a problem hiding this comment.
I think this test and the test below are thorough, yet it feels like testing an internal. It's HA Core's job to not add them. If there's a specific code path you want to test, for coverage, in your integration, we should write a test for that only. :)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
This adds the initial set of sensor platform to the Hotspring integration:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: