fix(java): support qualified generic type arguments#4455
Open
Baltsat wants to merge 1 commit into
Open
Conversation
User-Request: fix Java qualified generic highlighting | codex:019f8d3f
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +19 B View Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The Java grammar accepted only one identifier inside a generic type argument, so a declaration such as
List<java.lang.String> bar()was not recognized as a method.This change:
List<java.lang.String>regression to the existing Java generics fixture; andCHANGES.md.The behavior introduced by #4346 remains covered: all 11 Java markup fixtures pass, and top-level qualified declarations are unchanged.
Fixes #3677
Verification
npm run buildONLY_LANGUAGES=java npm run test-markup— 11 passingnpm run lint-languages— passednpm run lint— passed with one existing ignored-vendor warningnpm test— 1,583 passing, 3 pendinggit diff --check— passedsrc/languages/java.jsreproduced the focused failure; restoring it returned all 11 Java fixtures to green.A fresh
npm ciwas unavailable because registry DNS failed in the isolated Linux environment. Verification reused the exact unchanged lockfile dependency tree plus the official lock-resolved Rollup Linux package;npm ls --allreported 782 nodes and no problems.Checklist
CHANGES.mdAssistance disclosure
This patch and its verification were prepared with OpenAI Codex assistance. The final diff and test outputs were reviewed before publication.