Skip to content

fix: remove obsolete Flix grammar#4441

Open
iamdhrv wants to merge 1 commit into
highlightjs:mainfrom
iamdhrv:fix/4440-remove-obsolete-flix-grammar
Open

fix: remove obsolete Flix grammar#4441
iamdhrv wants to merge 1 commit into
highlightjs:mainfrom
iamdhrv:fix/4440-remove-obsolete-flix-grammar

Conversation

@iamdhrv

@iamdhrv iamdhrv commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Resolves #4440

Changes

  • Remove the obsolete built-in Flix grammar.
  • Remove its coupled markup and detection fixtures.
  • Keep the supported-languages entry pointing to the maintained third-party package.

Checklist

  • Markup tests do not apply because this removes the built-in grammar and its existing fixtures.
  • Updated the changelog at CHANGES.md.

Tests: npm run build, npm test.

@github-actions

Copy link
Copy Markdown

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

2 Removed Files

View Changes
file size
es/languages/flix.min.js -471 B
languages/flix.min.js -474 B

2 files changed

Total change -2 B

View Changes
file base pr diff
es/core.min.js 8.24 KB 8.24 KB -1 B
es/highlight.min.js 8.24 KB 8.24 KB -1 B

@iamdhrv
iamdhrv marked this pull request as ready for review July 15, 2026 02:59

@Baltsat Baltsat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the removal path against current main. The built-in Flix source and coupled fixtures are still present, while SUPPORTED_LANGUAGES.md keeps the maintained third-party highlightjs-flix path. The build loader discovers core grammars from src/languages/*.js and third-party grammars separately, so the five-file deletion is scoped consistently.

The original 18 checks are green, but GitHub now reports this head as conflicting with main, so those runs do not prove the current base. I found no source-level blocker after a rebase; the remaining step is to resolve the conflict and rerun CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flix overlap

2 participants