fix: remove stale chunking warning for espeak languages - #318
Open
semidark wants to merge 1 commit into
Open
Conversation
The warning 'Chunking logic not yet implemented' was added in Jan 2025 but sentence-level chunking was implemented in hexgrad#105 (Feb 2025). The warning is now misleading for all espeak-ng languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning in
KPipeline.__init__says "Chunking logic not yet implemented, so long texts may be truncated unless you split them with '\n'." for all espeak-ng languages.This was accurate when added in Jan 2025, but sentence-level chunking for non-English languages was implemented in #105 (Feb 2025). The warning was never removed and is now misleading.
One line removed, no behavioral change.